Always determine reader type based on mime type #181
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
createFromType
method and correspondingtype
property fromSimpleExcelReader
.createFromFile
with thecreateFromFileByMimeType
method exclusively.The reason for replacing calls to
createFromFile
is to allow any file to be processed correctly despite the file name. This is especially important when the original file has been renamed and no longer has a file extension. When working with uploaded files, the file name is always renamed to a generated string without the original extension. Always usingcreateFromFileByMimeType
should simplify the reader type detection and make it more consistent, since it is not dependent on the file extension.This is a breaking change, so it will need to be released in the next major version.