generated from spatie/package-skeleton-laravel
-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to optionally merge automatically inferred rules with manual rules #848
Open
CWAscend
wants to merge
9
commits into
spatie:main
Choose a base branch
from
CWAscend:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CWAscend
changed the title
Add the ability to optionally merge attribute rules with method rules
Add the ability to optionally merge automatically inferred rules with manual rules
Aug 19, 2024
Up |
rubenvanassche
requested changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Some changes required in order to get it merged.
@rubenvanassche thanks for the feedback, I'll action this over the weekend 👍 |
@rubenvanassche this is ready to be re-reviewed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💪 Motivation
I would like the ability to use a combination of Attribute rules and manual rules that are defined within the static
rules
method in aData
object. For me, this will massively clean up my rules method when I have to reach for it, such as which I might be reaching for acallable
rule, or using theRule::in()
rule where the array is dynamic - just to name some examples.🛠 Changes
Spatie\LaravelData\Attributes\MergeRules
attributetests/Fakes/DataWithMergedRuleset.php
🧪 Testing
it will merge validation rules
, which ensures both validation rules from the Attributes and the rules method are picked up.it will merge validation rules using string rules
which ensures the validation rules can be a piped string of rules instead of an array of files for each attribute🧙 Reminders (Author)