Implement MIRI IFU empirical cruciform #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…done this long ago!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Relocated from https://github.com/spacetelescope/webbpsf/pull/930]
Cloned from #928, and relocated into a PR branch owned by @mperrin. As noted in #928, the workflow for this one is atypical in that @patapisp started the branch and I @mperrin am now picking up to revise and finish it. By @patapisp:
This is the the start of a PR for finalising the broadening and cruciform implementation for the MIRI IFU mode. Added an additional option for
model_type = "cruciform"Remaining tasks:
oversampleparameter yields quite significant differences in the PSF models