Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the setup in the MIRI LRS slit spec3 regression test, to avoid problems that arise when things intentionally change. The problem is related to the fact that the test has 4 iterations to it, generating the same s2d product each time. At the same time it was using one of the truth files as WCS input information, from which to generate some of the later iterations of s2d products. So when the pipeline code or ref files change, the test was still using the WCS from the old truth file to generate the new s2d products. Then when "okify_regtests" tries to use the new s2d products to update the truth, it's using a result that was generated from the old truth file and hence doesn't actually accomplish the appropriate update.
So I've changed the mechanics of the test to use the WCS from the s2d product generated by the first iteration as the input to all the subsequent iterations. That way the later iterations are using the "new" WCS info.
Truth files on artifactory have been updated by hand to also get things into a good starting configuration going forward.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR