Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use stpipe.crds_client.reference_uri_to_cache_path #8542

Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jun 7, 2024

instead off Step.reference_uri_to_cache_path to allow it's removal in stpipe

Regression tests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1509/
show only unrelated failures (matching those for https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-Developers-Pull-Requests/detail/JWST-Developers-Pull-Requests/1508/pipeline

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.52%. Comparing base (b7e0b10) to head (4d19b45).
Report is 324 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8542      +/-   ##
==========================================
+ Coverage   58.02%   58.52%   +0.50%     
==========================================
  Files         388      388              
  Lines       38977    38957      -20     
==========================================
+ Hits        22617    22801     +184     
+ Misses      16360    16156     -204     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram force-pushed the reference_uri_to_cache_path branch from 89952dd to 06c6a6d Compare June 8, 2024 09:47
instead off Step.reference_uri_to_cache_path to allow it's removal
in stpipe
@braingram braingram force-pushed the reference_uri_to_cache_path branch from 06c6a6d to 69a70c4 Compare June 11, 2024 17:45
@braingram braingram marked this pull request as ready for review June 11, 2024 17:52
@braingram braingram requested a review from a team as a code owner June 11, 2024 17:52
@hbushouse hbushouse added this to the Build 11.0 milestone Jun 11, 2024
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@hbushouse hbushouse merged commit a3b0b67 into spacetelescope:master Jun 11, 2024
28 checks passed
@braingram braingram deleted the reference_uri_to_cache_path branch June 11, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants