-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3173: Add NIRSpec optical path constraints for TSO associations #8537
Conversation
Regression tests started here: |
Looking at regtest results... I was expecting the changes to test_against_standard[pool_021_tso] and test_against_standard[pool_022_tso_noflag]: I updated the pool files in the repository to give them the new values needed to plan NIRSpec TSO. The associations are still created, they just have different names. I did not expect the differences for these:
But it looks like all of these are using early pool files which have FXD_SLIT = null, so there are TSO associations that are no longer being created, even though they would be if FXD_SLIT was populated. I think the other changes are unrelated. I'm not sure why the jwst.associations.tests.test_level3_duplicate test failed, though. I can't reproduce it locally, on my branch or main. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8537 +/- ##
==========================================
+ Coverage 58.02% 58.13% +0.10%
==========================================
Files 388 388
Lines 38977 38972 -5
==========================================
+ Hits 22617 22655 +38
+ Misses 16360 16317 -43 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me.
Resolves JP-3173
Closes #8240
NIRSpec TSO associations are created via the general TSO rules (Asn_Lv2SpecTSO and Asn_Lv3TSO), which do not currently have a check on the valid optical paths for NIRSpec. This results in associations being created for NRS2 in some modes for which no light falls on that detector (e.g. S1600A1, prism, clear). This PR adds NIRSpec optical path constraints to the TSO rules.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionupdated relevant documentationHow to run regression tests on a PR