Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3173: Add NIRSpec optical path constraints for TSO associations #8537

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

melanieclarke
Copy link
Collaborator

@melanieclarke melanieclarke commented Jun 5, 2024

Resolves JP-3173

Closes #8240

NIRSpec TSO associations are created via the general TSO rules (Asn_Lv2SpecTSO and Asn_Lv3TSO), which do not currently have a check on the valid optical paths for NIRSpec. This results in associations being created for NRS2 in some modes for which no light falls on that detector (e.g. S1600A1, prism, clear). This PR adds NIRSpec optical path constraints to the TSO rules.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@melanieclarke
Copy link
Collaborator Author

@melanieclarke
Copy link
Collaborator Author

melanieclarke commented Jun 6, 2024

Looking at regtest results...

I was expecting the changes to test_against_standard[pool_021_tso] and test_against_standard[pool_022_tso_noflag]: I updated the pool files in the repository to give them the new values needed to plan NIRSpec TSO. The associations are still created, they just have different names.

I did not expect the differences for these:

  • test_against_standard[jw84600_20180824T212338_pool]
  • test_against_standard[jw93056_20171108T060152_pool]
  • test_against_standard[jw84600_20180824T212338-valid-msametfl_pool]]

But it looks like all of these are using early pool files which have FXD_SLIT = null, so there are TSO associations that are no longer being created, even though they would be if FXD_SLIT was populated.

I think the other changes are unrelated. I'm not sure why the jwst.associations.tests.test_level3_duplicate test failed, though. I can't reproduce it locally, on my branch or main.

@melanieclarke melanieclarke marked this pull request as ready for review June 6, 2024 17:03
@melanieclarke melanieclarke requested a review from a team as a code owner June 6, 2024 17:03
@melanieclarke melanieclarke requested a review from hbushouse June 6, 2024 17:03
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.13%. Comparing base (b7e0b10) to head (4ab595a).
Report is 317 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8537      +/-   ##
==========================================
+ Coverage   58.02%   58.13%   +0.10%     
==========================================
  Files         388      388              
  Lines       38977    38972       -5     
==========================================
+ Hits        22617    22655      +38     
+ Misses      16360    16317      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

@hbushouse hbushouse merged commit 41f24b7 into spacetelescope:master Jun 11, 2024
28 checks passed
@melanieclarke melanieclarke deleted the jp-3173 branch June 11, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spec2 ASN's created for NRS prism on NRS2 detector
2 participants