-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonification plugin tweaks #3377
Sonification plugin tweaks #3377
Conversation
…up-to-date n render
…ionality for flux %ile removal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't grok the algorithms but I left a general review. Hope this helps. Thanks.
@@ -3,7 +3,6 @@ | |||
import sys | |||
import os | |||
import time | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to remove this blank line.
This comment was marked as resolved.
This comment was marked as resolved.
… formatting Co-authored-by: P. L. Lim <[email protected]>
… formatting Co-authored-by: P. L. Lim <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3377 +/- ##
==========================================
- Coverage 88.01% 87.99% -0.02%
==========================================
Files 127 127
Lines 19747 19758 +11
==========================================
+ Hits 17381 17387 +6
- Misses 2366 2371 +5 ☔ View full report in Codecov by Sentry. |
Co-authored-by: P. L. Lim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried using a composite spectral subset and it seemed to work, although I will trust that you've tested that and confirmed it also. If that is the case then this is good to be merged! My only request (for either this PR or a follow up) is to use more descriptive variable names. The following names could be changed for clarities sake: lims
, wl_unit
, wl_bounds
, wlens
, eln
, assidx
, ssvidx
, and pccut
. Thanks again for getting composite subsets working!
Co-authored-by: Jesse Averbukh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks like code. Thanks!
Assuming CI is green, approving.
devdeps failures are unrelated. Merging. Thanks! |
Oh wait... remote data job failed in Catalogs. Maybe a network hiccup. Lemme restart. |
Description
This pull request develops the Sonification functionality further
flux_viewer.update_listener_wls
now takes a sequence of ranges rather than a min and max, to allow for composite selections with appropriate@observe
keyword for spectral subselection.vue
file.True
Fixes #
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.