Fix SDK build errors, plus add it to the CI #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdeme
commented
Oct 27, 2023
| apt-get install -y apt-transport-https && \ | ||
| apt-get update && \ | ||
| apt-get install -y dotnet-sdk-6.0 | ||
| RUN apt-get install -y dotnet-sdk-6.0 |
There was a problem hiding this comment.
dotnet is now part of the Ubuntu package manager and the build fails if you don't use that one. 😅
A fatal error occurred. The folder [/usr/share/dotnet/host/fxr] does not exist
peterdeme
commented
Oct 27, 2023
| @@ -65,7 +65,6 @@ build_nodejs:: install_plugins tfgen # build the node sdk | |||
| cd sdk/nodejs/ && \ | |||
| yarn install && \ | |||
| yarn run tsc && \ | |||
| cp -R scripts/ bin && \ | |||
There was a problem hiding this comment.
they have dropped the scripts folder: pulumi/pulumi#13195 (comment)
peterdeme
force-pushed
the
fix-build-error
branch
10 times, most recently
from
c6998ab to
5118f6a
Compare
peterdeme
changed the title
peterdeme
force-pushed
the
fix-build-error
branch
4 times, most recently
from
0049ca8 to
ec3fecf
Compare
Apprently Pulumi dropped the install script: pulumi/pulumi#13195 (comment) Signed-off-by: peterdeme <[email protected]>
peterdeme
force-pushed
the
fix-build-error
branch
from
ec3fecf to
5a768e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apprently Pulumi dropped the install script: pulumi/pulumi#13195 (comment)