Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DotNet] Add details to README in certificate samples #421

Closed
wants to merge 17 commits into from
Closed

[DotNet] Add details to README in certificate samples #421

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
373856a
include more details for local certificates
JhontSouth May 28, 2024
9b40447
include keyvault certificate guide details
JhontSouth May 28, 2024
f8239f6
reorganize certfiicate sample readme
JhontSouth May 29, 2024
cfa48e9
fix data tab
JhontSouth May 29, 2024
4bc9c17
include details in SNI smaple readme
JhontSouth May 29, 2024
b984c23
add az login step
JhontSouth Jun 4, 2024
afcca94
remove unnecesary step
JhontSouth Jun 6, 2024
59fda0d
Update README.md
sw-joelmut Jun 7, 2024
aad27a8
Merge pull request #429 from southworks/joelmut/review/PR421
JhontSouth Jun 10, 2024
25593c0
add important tag alert to sni sample
JhontSouth Jun 11, 2024
ee58c50
format SNI README
JhontSouth Jun 11, 2024
bfb73e1
clarify the consumption of certificate
JhontSouth Jun 11, 2024
bd4f5ed
use CertificateServiceClientCredentialsFactory for SN+I auth
JhontSouth Jun 18, 2024
f12f8fc
include SN+I details
JhontSouth Jun 19, 2024
ddebf9a
format
JhontSouth Jun 19, 2024
b928b19
fix conflicts
JhontSouth Jun 19, 2024
3924883
add sample information
JhontSouth Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion samples/csharp_dotnetcore/84.bot-authentication-certificate/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Bot Framework v4 bot authentication using Certificate

This bot has been created using [Bot Framework](https://dev.botframework.com/), is shows how to use the bot authentication capabilities of Azure Bot Service. In this sample, we use a local or KeyVault certificate to create the Bot Framework Authentication.
This bot has been created using [Bot Framework](https://dev.botframework.com/), it shows how to use the bot authentication capabilities of Azure Bot Service. In this sample, we use a local or KeyVault certificate to create the Bot Framework Authentication.

## Interacting with the bot

Expand Down Expand Up @@ -164,6 +164,11 @@ An SSL/TLS certificate is a digital object that allows systems to verify identit

![Certificate Reading](Images/KeyVault/CertificateReading.png)
JhontSouth marked this conversation as resolved.
Show resolved Hide resolved

7. In the current sample context, log into Azure to obtain the default credentials by executing the following command.
```
az login
```

- Run the bot from a terminal or from Visual Studio:

A) From a terminal, navigate to `samples/csharp_dotnetcore/84.bot-authentication-certificate`
Expand Down
7 changes: 6 additions & 1 deletion samples/csharp_dotnetcore/85.bot-authentication-sni/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Bot Framework v4 bot authentication using Subject Name/Issuer

This bot has been created using Bot Framework, is shows how to use the bot authentication capabilities of Azure Bot Service. In this sample, we use a local or KeyVault certificate and the MSAL Subject Name/Issuer configuration to create the Bot Framework Authentication.
This bot has been created using Bot Framework, it shows how to use the bot authentication capabilities of Azure Bot Service. In this sample, we use a local or KeyVault certificate and the MSAL Subject Name/Issuer configuration to create the Bot Framework Authentication.
>NOTE: Microsoft's first-party resources are required to test this sample.
JhontSouth marked this conversation as resolved.
Show resolved Hide resolved

## Interacting with the bot
Expand Down Expand Up @@ -146,6 +146,11 @@ Certificate Subject Name and Issuer (SNI) based authentication is currently avai

![Certificate Reading](Images/KeyVault/CertificateReading.png)

5. In the current sample context, log into Azure to obtain the default credentials by executing the following command.
```
az login
```

- Run the bot from a terminal or from Visual Studio:

A) From a terminal, navigate to `samples/csharp_dotnetcore/85.bot-authentication-sn`
Expand Down
Loading