feat: 멤버 로깅 추가 #1655
Merged
feat: 멤버 로깅 추가 #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🚀 프리뷰 배포 확인하기 🚀 |
seojisoosoo
reviewed
Nov 6, 2024
src/components/eventLogger/events.ts
Outdated
Comment on lines
19
to
23
| company: string; | ||
| job: string; | ||
| generation: number[]; | ||
| part: string[]; | ||
| university: string; |
There was a problem hiding this comment.
p1 도영아! 저희 로깅 프로퍼티가 변경되었어요!
organization, job, generation, part 입니다!
organization은 1. 재직여부 상관없이 가장 최근 company 2. company가 없다면 university에요!
관련슬랙링크 첨부할게요~
| /> | ||
| </> | ||
| )} | ||
| {!profile.isMine && <MessageSection profile={profile} memberId={memberId} />} |
seojisoosoo
approved these changes
Nov 6, 2024
company, university -> organization 으로 통일
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤫 쉿, 나한테만 말해줘요. 이슈넘버
🧐 어떤 것을 변경했어요~?
🤔 그렇다면, 어떻게 구현했어요~?
노션에 있는 로깅들 추가했습니다!
로컬에서는 잘 찍혔는데, Amplitude에서 잘 찍히는지 확인이 필요해요!
❤️🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.
📸 스크린샷, 없으면 이것 참,, 섭섭한데요?