Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 쪽지 보내기 모달 내 글자수 validation 서버와 불일치 문제 해결 #1652

Merged
merged 5 commits into from
Nov 4, 2024
Merged

fix: 쪽지 보내기 모달 내 글자수 validation 서버와 불일치 문제 해결 #1652

merged 5 commits into from
Nov 4, 2024

Conversation

simeunseo
Copy link
Member

@simeunseo simeunseo commented Nov 4, 2024 •
edited
Loading

🤫 쉿, 나한테만 말해줘요. 이슈넘버

🧐 어떤 것을 변경했어요~?

  • 쪽지 보내기 내용 글자수 제한이 750자로 되어있었는데, 서버측에서는 40자로 되어있어서 둘다 500자로 통일하는 작업을 거쳤습니다.
  • 기존 쪽지 보내기 기능에서 coffeechat 관련 필드가 지워지지 않은 것이 있어서 제거했습니다.
  • placeholder 변경 요청이 있어서 적용했습니다.

🤔 그렇다면, 어떻게 구현했어요~?

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

@simeunseo simeunseo added the 🐛 Bug 버그픽스 label Nov 4, 2024
@simeunseo simeunseo self-assigned this Nov 4, 2024
@height Height
Copy link

height bot commented Nov 4, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@github-actions github-actions bot requested a review from pepperdad November 4, 2024 13:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

✨✨ 스토리북으로 확인하기 ✨✨

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

🚀 프리뷰 배포 확인하기 🚀

https://dabbfc3b.sopt-internal-dev.pages.dev

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Nov 4, 2024
pepperdad
pepperdad approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@pepperdad pepperdad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!!!!

@simeunseo simeunseo changed the title fix: fix: 쪽지 보내기 모달 내 글자수 validation 서버와 불일치 문제 해결 fix: 쪽지 보내기 모달 내 글자수 validation 서버와 불일치 문제 해결 Nov 4, 2024
@simeunseo simeunseo added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 38f6e6b Nov 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepperdad pepperdad pepperdad approved these changes

Assignees

@simeunseo simeunseo

Labels
🐛 Bug 버그픽스 size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: 쪽지 보내기 모달 내 글자수 validation 서버와 불일치 문제
2 participants
@simeunseo @pepperdad