Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 커피챗 마무리작업 #1647

Merged
merged 5 commits into from
Nov 4, 2024
Merged

feat: 커피챗 마무리작업 #1647

merged 5 commits into from
Nov 4, 2024

Conversation

seojisoosoo
Copy link
Member

@seojisoosoo seojisoosoo commented Nov 3, 2024 •
edited
Loading

🤫 쉿, 나한테만 말해줘요. 이슈넘버

🧐 어떤 것을 변경했어요~?

  • 커피챗 마무리 작업 진행했어요.
    • 커피챗 상세 - 전화번호 없는 경우 폰 아이콘 노출되지 않도록 수정
    • 커피챗 수정 - 상세 내용 불러오기
    • 커피챗 오픈 - shift+enter disabled처리
    • 커피챗 오픈 버튼 연결
    • 리패치, 라우터 작업

🤔 그렇다면, 어떻게 구현했어요~?

  • TODO로 주석처리해둔 내용 반영했습니다!

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

  • 로깅, 커피챗 id 없는 페이지 접속/내 커피챗 아닌 커피챗 수정 시도 시 예외처리 진행 예정이에요

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

@height Height
Copy link

height bot commented Nov 3, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@seojisoosoo seojisoosoo self-assigned this Nov 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2024 •
edited
Loading

✨✨ 스토리북으로 확인하기 ✨✨

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2024 •
edited
Loading

🚀 프리뷰 배포 확인하기 🚀

https://fe192909.sopt-internal-dev.pages.dev

@seojisoosoo seojisoosoo marked this pull request as ready for review November 4, 2024 10:30
@github-actions github-actions bot requested a review from pepperdad November 4, 2024 10:30
hayounSong
hayounSong approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@hayounSong hayounSong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어!!

@seojisoosoo seojisoosoo added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 0a9d9bb Nov 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayounSong hayounSong hayounSong approved these changes

@pepperdad pepperdad Awaiting requested review from pepperdad

Assignees

@seojisoosoo seojisoosoo

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 커피챗 마무리 작업
2 participants
@seojisoosoo @hayounSong