Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 커피솝(커피챗) 플레이그라운드 헤더 추가 #1629

Merged
merged 6 commits into from
Nov 2, 2024

Conversation

hayounSong
Copy link
Contributor

🤫 쉿, 나한테만 말해줘요. 이슈넘버

🧐 어떤 것을 변경했어요~?

플레이그라운드 헤더를 업데이트하고, 배포를 완료했습니다.(1.5.2 -> 1.6.2)

🤔 그렇다면, 어떻게 구현했어요~?

하면서, 노션을 조금 업데이트 하고있습니다. 미래의 플둥이들 화이팅..
그리고, 크루팀과 의견 조율을 위해서 슬랙 메시지를 드린 상태입니다!

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

@hayounSong hayounSong self-assigned this Nov 1, 2024
Copy link

height bot commented Nov 1, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

github-actions bot commented Nov 2, 2024

✨✨ 스토리북으로 확인하기 ✨✨

Copy link

github-actions bot commented Nov 2, 2024

🚀 프리뷰 배포 확인하기 🚀

https://d8c458b8.sopt-internal-dev.pages.dev

Copy link
Member

@seojisoosoo seojisoosoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!
미래의 플둥을 위한 문서작업까지... 정말 최고에요!

@@ -44,6 +44,10 @@ const DesktopHeader: FC<DesktopHeaderProps> = ({ user, onLogout, renderLink, act
href: playgroundLink.groupList(),
children: <NavItem isActive={activePathMatcher(playgroundLink.groupList())}>모임</NavItem>,
})}
{renderLink({
href: playgroundLink.coffeechat(),
children: <NavItem isActive={activePathMatcher(playgroundLink.coffeechat())}>커피솝</NavItem>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

귀엽다 커피솝...

@@ -95,6 +95,14 @@ const MobileSideBar: FC<MobileSideBarProps> = ({
모임
</NavItem>
),
})}
{renderLink({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오잉 여기 정렬이 맞지 않는것 같아요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제 pc eslint가 계속 말썽이네요..감사합니다!

@hayounSong hayounSong added this pull request to the merge queue Nov 2, 2024
Merged via the queue into main with commit cf87100 Nov 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 플레이그라운드 헤더 커피챗 추가
2 participants