Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 커피챗 상세 페이지 구현 #1620

Merged
merged 4 commits into from
Nov 1, 2024
Merged

feat: 커피챗 상세 페이지 구현 #1620

merged 4 commits into from
Nov 1, 2024

Conversation

seojisoosoo
Copy link
Member

@seojisoosoo seojisoosoo commented Oct 30, 2024 •
edited
Loading

🤫 쉿, 나한테만 말해줘요. 이슈넘버

🧐 어떤 것을 변경했어요~?

  • 커피챗 상세 구현하기

🤔 그렇다면, 어떻게 구현했어요~?

  • 페이지의 memberId를 읽어온 뒤, 해당값을 props로 내려주었어요. 분리한 컴포넌트마다 파라미터를 읽고 status 처리하는 게 불편할 것 같아서, 부모 컴포넌트에서 선언 후 props로 내려주었습니다.
  • 커피챗 정보는 각 컴포넌트마다 훅으로 호출했습니다.

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

  • mds 태그 이용했고, 도영이가 분리해준 공통 컴포넌트 잘 사용했습니다!
  • 커피챗 프로필 쪽에서 데스크탑/모바일의 레이아웃이 다른 경우가 있어서 grid를 이용하여 위치를 조정해주었어요

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

스크린샷 2024-10-31 오전 12 34 42

@height Height
Copy link

height bot commented Oct 30, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@seojisoosoo seojisoosoo self-assigned this Oct 30, 2024
@github-actions github-actions bot requested a review from pepperdad October 30, 2024 15:35
@seojisoosoo seojisoosoo changed the base branch from main to feat/coffechat-detail October 30, 2024 15:35
@github-actions GitHub Actions
Copy link

✨✨ 스토리북으로 확인하기 ✨✨

@github-actions GitHub Actions
Copy link

🚀 프리뷰 배포 확인하기 🚀

https://f7fa0ae1.sopt-internal-dev.pages.dev

@seojisoosoo seojisoosoo changed the title Feat/#1606 detail feat: 커피챗 상세 페이지 구현 Oct 30, 2024
pepperdad
pepperdad reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@pepperdad pepperdad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 고생하셨어요~!!

섹션 Color 다른 것만 확인해주세요!

src/components/coffeechat/detail/index.tsx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p1:
image
여기 섹션 별로 색이 조금 달라요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사해요!!

src/components/coffeechat/detail/index.tsx
return (
<DetailPageLayout>
<DetailPage>
<CoffeechatLoading />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q:
이건 어떤 역할을 하는 컴포넌트인가요??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거.... 로딩 컴포넌트 확인하느라고 넣어두었는데 삭제를 못했네요... 감사합니다!!

@hayounSong hayounSong merged commit 7fc7156 into feat/coffechat-detail Nov 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepperdad pepperdad pepperdad left review comments

@hayounSong hayounSong hayounSong approved these changes

Assignees

@seojisoosoo seojisoosoo

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 커피챗 상세 구현하기
3 participants
@seojisoosoo @hayounSong @pepperdad