feat: 커피챗 오픈/수정 로직 구현 #1604
Merged
feat: 커피챗 오픈/수정 로직 구현 #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🚀 프리뷰 배포 확인하기 🚀 |
hayounSong
approved these changes
Oct 26, 2024
| <ChipsWrapper {...field}> | ||
| {chipList.map((chip) => ( | ||
| <div | ||
| key={chip} |
| value={field.value ?? ''} | ||
| placeholder='ex. 디자인 관련 고민이 있다면, 함께 나눠봐요!' | ||
| maxLength={40} | ||
| isError={!!errors.coffeeChatInfo?.bio} |
There was a problem hiding this comment.
여길 느낌표 2개로 구현해준 이유가 있을까요?!
There was a problem hiding this comment.
아하 이거 errors.coffeeChatInfo?.bio가 있으면 true, 없으면 false라는 의미로 쓰고 싶어서 boolean 타입이 되어지도록 !!을 붙여주었습니다!
| onSuccess: async () => { | ||
| // TODO: 쿼리 무효화 및 페이지 이동 처리 | ||
| // queryClient.invalidateQueries({ queryKey: 'coffeechat' }); | ||
| // await router.push(playgroundLink.coffeechat()); |
There was a problem hiding this comment.
여기 향후를 위한 코드 너무 좋은 것 같아유 배워갑니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
한 브랜치에 넘 많은 작업을 했습니다... 반성합니다.,,
🤫 쉿, 나한테만 말해줘요. 이슈넘버
🧐 어떤 것을 변경했어요~?
🤔 그렇다면, 어떻게 구현했어요~?
❤️🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.
📸 스크린샷, 없으면 이것 참,, 섭섭한데요?