feat: 커피챗 입력 progress 박스 구현 #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🚀 프리뷰 배포 확인하기 🚀 |
pepperdad
approved these changes
Oct 18, 2024
| import { IconCheck } from '@sopt-makers/icons'; | ||
|
|
||
| interface ProgressBoxProps { | ||
| uploadType: string; |
There was a problem hiding this comment.
p2: uploadTyped이 오픈이랑 수정밖에 없으면 리터럴 타입으로 제한하는 게 좋아보여요!
Comment on lines
93
to
99
| {isInprogress ? ( | ||
| <IconCheckCircle isInprogress> | ||
| <IconCheck /> | ||
| </IconCheckCircle> | ||
| ) : ( | ||
| <IconCheckCircle isInprogress={isInprogress} /> | ||
| )} |
There was a problem hiding this comment.
p2: 이 부분은 아래처럼 간소화하는 게 어떨까요?
Suggested change
| {isInprogress ? ( | |
| <IconCheckCircle isInprogress> | |
| <IconCheck /> | |
| </IconCheckCircle> | |
| ) : ( | |
| <IconCheckCircle isInprogress={isInprogress} /> | |
| )} | |
| <IconCheckCircle isInProgress={isInProgress}> | |
| {isInProgress && <IconCheck />} | |
| </IconCheckCircle> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤫 쉿, 나한테만 말해줘요. 이슈넘버
🧐 어떤 것을 변경했어요~?
🤔 그렇다면, 어떻게 구현했어요~?
❤️🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.
📸 스크린샷, 없으면 이것 참,, 섭섭한데요?