feat: 프로필 내 모임추가 #1286
Closed
feat: 프로필 내 모임추가 #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 프리뷰 배포 확인하기 🚀 |
juno7803
reviewed
Jan 28, 2024
Comment on lines
58
to
62
| const { data: meetingList } = useQuery({ | ||
| queryKey: ['getMeetings'], | ||
| queryFn: () => getMeetings(Number(memberId) ?? undefined), | ||
| }); | ||
| console.log(meetingList); |
There was a problem hiding this comment.
Suggested change
| const { data: meetingList } = useQuery({ | |
| queryKey: ['getMeetings'], | |
| queryFn: () => getMeetings(Number(memberId) ?? undefined), | |
| }); | |
| console.log(meetingList); | |
| const { data: meetingList } = useQuery({ | |
| queryKey: ['getMeetings', memberId], // 1. 쿼리키에 추가가 필요할 것 같아요! | |
| queryFn: () => getMeetings(Number(memberId) ?? undefined), | |
| }); |
- memberId 도 string을 number로 캐스팅 하고(이게 타입 안맞거나 하면 NaN 되어버리거나 하는 위험이 있어서..!) 저걸 다시 어차피 getMeetings에서 string으로 바꿔서 쓰니까 애초에 getMeetings에 string으로 받아도 좋을 것 같아요!
쿼리키는 꼭 넣어주시구 이대로도 잘 동작한다면 2번은 나중에 반영해도 될 것 같아요!
There was a problem hiding this comment.
급하게 하느라 꼼꼼하지 못했는데.. 챙겨주셔서 넘 감사합니다ㅜㅜ
2024-01-28.2.36.12.mov모바일 뷰에서 맨 아래쪽 영역이 잘 안나오는 것 같아요! import { Spacing } from '@toss/emotion-utils';
<Spacing size={400} />@seojisoosoo 맨 아래에 이 정도 추가해볼 수 있을까요?! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤫 쉿, 나한테만 말해줘요. 이슈넘버
🧐 어떤 것을 변경했어요~?
🤔 그렇다면, 어떻게 구현했어요~?
❤️🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.
📸 스크린샷, 없으면 이것 참,, 섭섭한데요?