Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ExceptionHandler 예외 메시지 구체화 및 번쩍 관련 로직 수정 #537

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

hoonyworld
Copy link
Member

👩‍💻 Contents

  • ExceptionHandler 예외 메시지를 구체화하였습니다.
  • Valid 어노테이션과 관련해서 번쩍 관련 로직을 수정했습니다.

📝 Review Note

image
image

  • 예외 메시지를 구체화 처리함으로서 클라이언트 측에서 예외 대응을 빠르게 할 수 있도록 하였습니다.

📣 Related Issue

✅ 점검사항

  • docker-compose.yml 파일에 마이그레이션 한 API의 포워딩을 변경해줬나요?
  • Spring Secret 값을 수정하거나 추가했다면 Github Secret에서 수정을 해줬나요?
  • Nestjs Secret 값을 수정하거나 추가했다면 Docker-Compose.yml 파일 및 인스턴스 내부의 .env 파일을 수정했나요?

- 숫자 타입은 Min과 Max로 크기 산정
- DTO 내부 또 다른 DTO가 있으면 해당 DTO에는 Valid 어노테이션이 도달하지 못함
- 따라서 DTO에 직접 명시를 해줘야 하는 것을 알게됨
@hoonyworld hoonyworld added the 🛠️ refactor 리팩토링 및 개선 label Jan 20, 2025
@hoonyworld hoonyworld requested a review from mikekks January 20, 2025 16:17
@hoonyworld hoonyworld self-assigned this Jan 20, 2025
@hoonyworld hoonyworld linked an issue Jan 20, 2025 that may be closed by this pull request
1 task
Copy link

height bot commented Jan 20, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

mikekks
mikekks previously approved these changes Jan 20, 2025
Copy link
Member

@mikekks mikekks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오우 예외처리를 엄청 꼼꼼히 해주셨군여.. 고생하셨습니다 !!!

Copy link
Member

@mikekks mikekks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다~~

@hoonyworld hoonyworld merged commit 66fdcb3 into develop Jan 21, 2025
1 check passed
@mikekks mikekks deleted the refactor/#536 branch January 21, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ refactor 리팩토링 및 개선 size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: ExceptionHandler 에러 메시지 구체화
2 participants