-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Baseline Profiles 탑재 작업 #453
Baseline Profiles 탑재 작업 #453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 참고해주세요! 고생많았습니다.
|
||
@Test | ||
fun generate() { | ||
rule.collect("org.sopt.official") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
패키지 네임 상수로 바꿔주세요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지금 테스트가 Cold start에서만 돌고 있는 것 같은데, Warm과 Hot일 때도 어떻게 도는지 보면 좋을 것 같아요
@l2hyunwoo 위 코멘트 수정 및 셋팅 추가했습니다 🙏 |
7b2625f
to
7e905fa
Compare
7e905fa
to
afb318f
Compare
868fc4c
to
89cd6ad
Compare
83f2d46
to
946c159
Compare
e6a4815
to
53b20dd
Compare
946c159
to
9162392
Compare
5ea1c13
to
08a1719
Compare
76809db
to
33e77c0
Compare
c0b038a
to
e836aec
Compare
e836aec
to
8c05ce4
Compare
8c05ce4
to
a56d018
Compare
feat(baselineprofile): Add Warm Hot BenchMark feat(baselineprofile): Remove Test Device
cd0429e
to
56129ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 고생하셨습니다 @KwakEuiJin
What is this issue?
close #449
Reference
테스트 결과
테스트 모수를 20으로 임의적으로 늘렸습니다.
None Compile : 393.7 ms
Full Complie: 383.0 ms
BaseLineProfiles Compile: 349.0 ms
BaseLineProfiles Disable Compile: 270.8 ms
공식문서는 벤치마크 결과는 [컴파일 없음(324ms), 전체 컴파일(315ms), 부분 컴파일(312ms) 및 기준 프로필(229ms)] 이던데 왜 제 결과와 다른지 조금 의문이네요...
특히 Disable이 너무 빠른 건 무언가 측정상의 오류일까요 앱 특성인지 추론이 필요할 것 같습니다.
테스트 인증샷