Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline Profiles 탑재 작업 #453

Merged
merged 5 commits into from
May 26, 2024

Conversation

kez-lab
Copy link
Contributor

@kez-lab kez-lab commented Nov 15, 2023

What is this issue?

close #449

Reference

테스트 결과

테스트 모수를 20으로 임의적으로 늘렸습니다.

None Compile : 393.7 ms
Full Complie: 383.0 ms
BaseLineProfiles Compile: 349.0 ms
BaseLineProfiles Disable Compile: 270.8 ms

공식문서는 벤치마크 결과는 [컴파일 없음(324ms), 전체 컴파일(315ms), 부분 컴파일(312ms) 및 기준 프로필(229ms)] 이던데 왜 제 결과와 다른지 조금 의문이네요...
특히 Disable이 너무 빠른 건 무언가 측정상의 오류일까요 앱 특성인지 추론이 필요할 것 같습니다.

ColdStartupBenchmark_startupNoCompilation
timeToInitialDisplayMs   min 346.1,   median 393.7,   max 405.0
Traces: Iteration 0 1 2 3 4
ColdStartupBenchmark_startupFullCompilation
timeToInitialDisplayMs   min 360.1,   median 383.0,   max 400.5
Traces: Iteration 0 1 2 3 4
ColdStartupBenchmark_startupBaselineProfile
timeToInitialDisplayMs   min 327.3,   median 349.0,   max 363.8
Traces: Iteration 0 1 2 3 4
ColdStartupBenchmark_startupBaselineProfileDisabled
timeToInitialDisplayMs   min 252.0,   median 270.8,   max 326.3
Traces: Iteration 0 1 2 3 4

테스트 인증샷

KakaoTalk_Photo_2023-11-15-20-16-00

@kez-lab kez-lab requested a review from a team as a code owner November 15, 2023 07:47
Copy link
Member

@l2hyunwoo l2hyunwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 참고해주세요! 고생많았습니다.


@Test
fun generate() {
rule.collect("org.sopt.official") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

패키지 네임 상수로 바꿔주세요!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지금 테스트가 Cold start에서만 돌고 있는 것 같은데, Warm과 Hot일 때도 어떻게 도는지 보면 좋을 것 같아요

@kez-lab
Copy link
Contributor Author

kez-lab commented Nov 15, 2023

@l2hyunwoo 위 코멘트 수정 및 셋팅 추가했습니다 🙏
테스트 결과는 description에 update해두었습니다!
확인해주시면 감사하겠습니다~!!

@l2hyunwoo l2hyunwoo force-pushed the feature/baseprofile_benchmark branch from 7b2625f to 7e905fa Compare November 23, 2023 13:44
@l2hyunwoo l2hyunwoo force-pushed the feature/baseprofile_benchmark branch from 7e905fa to afb318f Compare December 7, 2023 03:58
@l2hyunwoo l2hyunwoo force-pushed the feature/baseprofile_benchmark branch 2 times, most recently from 868fc4c to 89cd6ad Compare February 7, 2024 03:32
@l2hyunwoo l2hyunwoo force-pushed the feature/baseprofile_benchmark branch 2 times, most recently from 83f2d46 to 946c159 Compare March 3, 2024 11:06
@l2hyunwoo l2hyunwoo force-pushed the develop branch 2 times, most recently from e6a4815 to 53b20dd Compare April 4, 2024 00:38
@l2hyunwoo l2hyunwoo force-pushed the feature/baseprofile_benchmark branch from 946c159 to 9162392 Compare April 4, 2024 07:56
@l2hyunwoo l2hyunwoo force-pushed the feature/baseprofile_benchmark branch 2 times, most recently from 76809db to 33e77c0 Compare April 15, 2024 15:59
@l2hyunwoo l2hyunwoo force-pushed the feature/baseprofile_benchmark branch 3 times, most recently from c0b038a to e836aec Compare April 22, 2024 05:57
@l2hyunwoo l2hyunwoo force-pushed the feature/baseprofile_benchmark branch from e836aec to 8c05ce4 Compare May 7, 2024 15:28
@l2hyunwoo l2hyunwoo force-pushed the feature/baseprofile_benchmark branch from 8c05ce4 to a56d018 Compare May 24, 2024 02:43
kez-lab and others added 2 commits May 26, 2024 15:09
feat(baselineprofile): Add Warm Hot BenchMark

feat(baselineprofile): Remove Test Device
@l2hyunwoo l2hyunwoo force-pushed the feature/baseprofile_benchmark branch from cd0429e to 56129ff Compare May 26, 2024 06:09
Copy link
Member

@l2hyunwoo l2hyunwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 고생하셨습니다 @KwakEuiJin

@l2hyunwoo l2hyunwoo merged commit f1e0f23 into sopt-makers:develop May 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Add Baseline Profile in SOPT APP
2 participants