fix: Snmpv3 user lookup (#4)

sophos · Nov 25, 2024 · 2ff8772 · 2ff8772
1 parent e706997
commit 2ff8772
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "sophos-firewall-audit"
-version = "1.0.9"
+version = "1.0.10"
 description = "Sophos Firewall Audit"
 authors = ["Matt Mullen <[email protected]>"]
 readme = "README.md"

diff --git a/sophos_firewall_audit/rules/snmpv3.py b/sophos_firewall_audit/rules/snmpv3.py
@@ -30,7 +30,7 @@ def eval_snmpv3(fw_obj: SophosFirewall,
 
     for i in range(1,3):
         try:
-            result = fw_obj.get_snmpv3_user()
+            result = fw_obj.get_tag_with_filter(xml_tag="SNMPv3User", key="Username", value=expected["Username"])
         except SophosFirewallZeroRecords:
             result = None
             break
@@ -47,7 +47,7 @@ def eval_snmpv3(fw_obj: SophosFirewall,
     if result:
         actual = result["Response"]["SNMPv3User"]
     else:
-        actual = {}
+        actual = {"Username": "User not found"}
 
     result_dict = {
         "snmpv3": {