Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize counter initialization #1862

Merged
merged 4 commits into from
Jan 25, 2025

Conversation

stephenxs
Copy link
Collaborator

Optimize counter initialization by reducing the number of bulk counter poll calls during initialization.

Signed-off-by: Stephen Sun <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

No pipelines are associated with this pull request.

@stephenxs stephenxs requested a review from kcudnik December 13, 2024 12:58
@stephenxs
Copy link
Collaborator Author

Supplied benchmark data on the latest image (without vendor SAI mutex on counter polling APIs)
Vendor SAI's implementation takes most of time in bulk counter-polling SAI API call during initialization

@kcudnik
Copy link
Contributor

kcudnik commented Jan 23, 2025

should i marge this ?

@stephenxs
Copy link
Collaborator Author

should i marge this ?

Yes, please. Thank you.

@kcudnik kcudnik merged commit 3c6bd92 into sonic-net:master Jan 25, 2025
1 check passed
@stephenxs stephenxs deleted the optimize-counter-initialization branch January 25, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants