Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I worked on my vite-plugin-solid, it came to my attention that a certain version of Vite broke the resolution of
solid-js/web
.Digging a bit, I found it to be related to this issue: vitejs/vite#1418. As it turn out Jason Miller is on a mission to unify bundlers to try and be spec compliant.
The way Evan You handled it in Vite is that he resolves then
browser
entry, thennode
entry and then the defaultimport
. Sincenode
is above the defaults in thesolid-js/web
export mapping, this is the one being picked up by Vite (and supposedly other tool that follows this spec I suppose).Therefore, I do believe that adding a
browser
entry above thenode
one should suffice to fix the issue.I don't think it should impact anything, but I could be wrong on that one.
edit: Patching the node_modules manually, indeed fix the issue.