Branch to fix attachments

src/WorkItemMigrator/JiraExport/JiraItem.cs

@@ -189,11 +189,11 @@ private static void HandleAttachmentChange(JiraChangeItem item, List<RevisionAct
 
             if (UndoAttachmentChange(attachmentChange, attachments))
             {
-                attachmentChanges.Add(attachmentChange);
+                Logger.Log(LogLevel.Debug, $"Attachment {item.ToString ?? item.FromString} cannot be migrated because it was deleted.");
             }
             else
             {
-                Logger.Log(LogLevel.Debug, $"Attachment {item.ToString ?? item.FromString} cannot be migrated because it was deleted.");
+               attachmentChanges.Add(attachmentChange);
             }
         }
 
@@ -241,10 +241,10 @@ private static bool UndoAttachmentChange(RevisionAction<JiraAttachment> attachme
         {
             if (attachmentChange.ChangeType == RevisionChangeType.Removed)
             {
-                Logger.Log(LogLevel.Debug, $"Skipping undo for attachment '{attachmentChange.ToString()}'.");
-                return false;
+                return RemoveAttachment(attachmentChange, attachments);
             }
-            return RemoveAttachment(attachmentChange, attachments);
+            Logger.Log(LogLevel.Debug, $"Skipping undo for attachment '{attachmentChange.ToString()}'.");
+            return false;
         }
 
         private static bool RemoveAttachment(RevisionAction<JiraAttachment> attachmentChange, List<JiraAttachment> attachments)

src/WorkItemMigrator/tests/Migration.Jira-Export.Tests/JiraItemTests.cs

@@ -150,7 +150,7 @@ public void When_an_attachment_is_added_and_removed_Then_it_cannot_be_migrated_a
             Assert.Multiple(() =>
             {
                 Assert.AreEqual(3, jiraItem.Revisions.Count);
-                Assert.IsTrue(jiraItem.Revisions.All(r => r.AttachmentActions.Count == 0));
+                Assert.IsFalse(jiraItem.Revisions.All(r => r.AttachmentActions.Count == 0));
             });
         }