This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
support for default domain in jumpgate.conf #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds support for the specification of the default domain to use when booting servers in the conf file rather than hardcoding it to 'jumpgate.com' in the py code. this is a partial implementation of #63 which allows configurable domain per jumpgate service. a future PR will include additional support such as that discussed in #63
|
@sudorandom & @beittenc any comments on this one? fairly minimal changes IMO |
|
Ah, yes. This LGTM |
|
@beittenc any comments or can this be merged? |
|
@beittenc any comments on this one? |
sudorandom
added a commit
that referenced
this pull request
Apr 1, 2014
support for default domain in jumpgate.conf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for the specification of the default domain to use when
booting servers in the conf file rather than hardcoding it to
'jumpgate.com' in the py code. this is a partial implementation of
#63 which allows
configurable domain per jumpgate service. a future PR will include
additional support such as that discussed in
#63