Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FinalizerOptional trait #231

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

jacob-hughes
Copy link
Contributor

No description provided.

@ltratt ltratt added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@jacob-hughes
Copy link
Contributor Author

Fixed in f47421d, I don't think it should be squashed

@ltratt ltratt added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@jacob-hughes
Copy link
Contributor Author

We need to use the latest version of debian to build LLVM in CI as it requires a more recent version of CMake. Fixed here (6f3d526)

@ltratt ltratt added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@jacob-hughes
Copy link
Contributor Author

Fixed here ff35599

@ltratt
Copy link
Member

ltratt commented Oct 23, 2024

Please squash (if needed).

We build Alloy in CI, which requires us to have LLVM installed. Rust
no longer provides LLVM binaries for our rustc version so we must build
it ourselves.
@jacob-hughes jacob-hughes force-pushed the rename_finalizer_optional branch from ff35599 to 09a93a4 Compare October 23, 2024 15:44
@jacob-hughes
Copy link
Contributor Author

Squashed

@ltratt ltratt added this pull request to the merge queue Oct 23, 2024
Merged via the queue into softdevteam:master with commit da279bc Oct 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants