Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Form::submit helper #16108

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

marcusmoore
Copy link
Collaborator

This PR migrates calls to Form::submit to plain old html.

Pages Affected

Copy link

what-the-diff bot commented Jan 22, 2025

PR Summary

  • Simplified Button Implementation
    We have replaced a more complex button creation process with a standard and simpler approach using <input type="submit">. Now, both cancel and request buttons fall under this simplified process. This change should make the code more understandable and easier to maintain.

@snipe snipe merged commit 63838f6 into snipe:develop Jan 22, 2025
9 checks passed
@marcusmoore marcusmoore deleted the chore/migrate-form-submit-helper branch January 22, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants