Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/sync snappcloud #8

Open
wants to merge 228 commits into
base: snappcloud
Choose a base branch
from

fix: correct some issues

1066071
Select commit
Loading
Failed to load commit list.
Open

Chore/sync snappcloud #8

fix: correct some issues
1066071
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 18, 2024 in 0s

81.38% (+2.95%) compared to 223d8a8

View this Pull Request on Codecov

81.38% (+2.95%) compared to 223d8a8

Details

Codecov Report

Attention: Patch coverage is 79.21951% with 213 lines in your changes are missing coverage. Please review.

Project coverage is 81.38%. Comparing base (223d8a8) to head (1066071).
Report is 124 commits behind head on snappcloud.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           snappcloud       #8      +/-   ##
==============================================
+ Coverage       78.42%   81.38%   +2.95%     
==============================================
  Files             138      133       -5     
  Lines           19368    16033    -3335     
==============================================
- Hits            15189    13048    -2141     
+ Misses           3879     2679    -1200     
- Partials          300      306       +6     
Files Coverage Δ
cmd/contour/bootstrap.go 100.00% <ø> (ø)
cmd/contour/certgen.go 52.63% <100.00%> (+1.90%) ⬆️
cmd/contour/contour.go 0.00% <ø> (ø)
cmd/contour/gatewayprovisioner.go 43.42% <100.00%> (-0.46%) ⬇️
internal/annotation/annotations.go 100.00% <100.00%> (ø)
internal/certgen/output.go 56.00% <100.00%> (+6.00%) ⬆️
internal/contour/metrics.go 68.96% <100.00%> (-2.25%) ⬇️
internal/dag/accessors.go 87.43% <100.00%> (+0.76%) ⬆️
internal/dag/builder.go 93.18% <100.00%> (-0.16%) ⬇️
internal/dag/dag.go 98.44% <100.00%> (-0.26%) ⬇️
... and 61 more

... and 63 files with indirect coverage changes