-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ccip message received assertion #16072
base: develop
Are you sure you want to change the base?
Add ccip message received assertion #16072
Conversation
I see you updated files related to |
Quality Gate failedFailed conditions See analysis details on SonarQube Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
AER Report: CI Coreaer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , test-scripts , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , GolangCI Lint (.) , Core Tests (go_core_race_tests) , GolangCI Lint (integration-tests) , lint , SonarQube Scan 1. Linting errors in
|
This pull request includes significant updates to the
MaybeRevertMessageReceiver
contract and related integration tests. The changes enhance the contract's functionality, improve error handling, and extend the test coverage to ensure robustness.Contract Enhancements:
Unauthorized
,InsufficientBalance
,TransferFailed
) and events (FundsWithdrawn
,TokensWithdrawn
) to theMaybeRevertMessageReceiver
contract.onlyManager
modifier to restrict certain functions to the contract manager.Integration Test Updates:
SendRequest
function inccip_helpers.go
to return message data and handle additional error cases. [1] [2] [3] [4]MessageReceived
event and a function to assert that the message content matches the expected content. [1] [2]DeployContracts
function to log the deployment of the receiver Dapp and set a flag indicating its deployment status. [1] [2]CCIPLane
struct and related functions to handle and validate message data. [1] [2] [3] [4] [5]Dependency Updates:
MaybeRevertMessageReceiver
ingenerated-wrapper-dependency-versions-do-not-edit.txt
.maybe_revert_message_receiver
inccip_helpers.go
.