Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update brsmatch() to handle NA rows #17

Merged
merged 4 commits into from
Feb 3, 2024
Merged

Update brsmatch() to handle NA rows #17

merged 4 commits into from
Feb 3, 2024

Conversation

skent259
Copy link
Owner

@skent259 skent259 commented Feb 3, 2024

  • Remove rows with NA that isn't in the trt_time column
  • Minor internal code update to .brsmatch for cleaner code
  • Add tests to check for this going forward

@skent259
Update brsmatch() to handle NA rows
21b55c7 
* Remove rows with NA that isn't in the `trt_time` column
* Minor internal code update to .brsmatch for cleaner code
* Add tests to check for this going forward
@skent259
Update coxpsmatch() to handle NA rows
ad9add1 
* Same fix as brsmatch function
* Add testing
@skent259
Increment version and NEWS.md
11ee8b7
@skent259
fix Namespace issue
91f0b0f
@skent259 skent259 linked an issue Feb 3, 2024 that may be closed by this pull request
NA rows in df will cause uninformative error for brsmatch() #16
Closed
@skent259 skent259 merged commit e068b02 into master Feb 3, 2024
5 checks passed
@skent259 skent259 deleted the fix-nainput branch February 3, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NA rows in df will cause uninformative error for brsmatch()
1 participant
@skent259