Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin API openSetting #13761

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Jan 8, 2025

It's tricky to hook a bunch of things from html layer. I need to expose this func as API for my plugin to use

@github-actions github-actions bot changed the base branch from master to dev January 8, 2025 16:19
Copy link

github-actions bot commented Jan 8, 2025

Your PR was set to target master, PRs should be target dev
The base branch of this PR has been automatically changed to dev, please check that there are no merge conflicts

@zxkmm zxkmm marked this pull request as ready for review January 8, 2025 16:19
@zxkmm
Copy link
Contributor Author

zxkmm commented Jan 8, 2025

node的头文件我就先不去改了,如果需要我在那边PR的话麻烦告知我,谢谢

@zxkmm zxkmm changed the title Expose openSetting fucnc to plugin APIs Expose openSetting func to plugin APIs Jan 8, 2025
@88250 88250 requested a review from Vanessa219 January 11, 2025 02:57
app/SiYuan-Kernel Outdated Show resolved Hide resolved
@Vanessa219 Vanessa219 added this to the 3.1.20 milestone Jan 11, 2025
@Vanessa219 Vanessa219 merged commit 514e4da into siyuan-note:dev Jan 11, 2025
Vanessa219 added a commit that referenced this pull request Jan 11, 2025
@Vanessa219 Vanessa219 changed the title Expose openSetting func to plugin APIs Add plugin util openSetting Jan 11, 2025
@zxkmm
Copy link
Contributor Author

zxkmm commented Jan 11, 2025

谢谢合并。请问npm的头文件需要我去pr吗?

@Vanessa219 Vanessa219 changed the title Add plugin util openSetting Add plugin function openSetting Jan 11, 2025
Vanessa219 added a commit to siyuan-note/petal that referenced this pull request Jan 11, 2025
@zxkmm zxkmm deleted the expose_openSetting_to_plugin branch January 11, 2025 13:37
Vanessa219 added a commit to siyuan-note/petal that referenced this pull request Jan 11, 2025
Vanessa219 added a commit to siyuan-note/plugin-sample that referenced this pull request Jan 11, 2025
Vanessa219 added a commit that referenced this pull request Jan 11, 2025
@Vanessa219
Copy link
Member

不需要了,已修改。

@Vanessa219 Vanessa219 self-assigned this Jan 11, 2025
@88250 88250 changed the title Add plugin function openSetting Add plugin API openSetting Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants