-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: css module 번들 이슈 수정 #63
Conversation
🦋 Changeset detectedLatest commit: 620784a The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
개요Walkthrough이 풀 리퀘스트는 Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (18)
✅ Files skipped from review due to trivial changes (16)
🔇 Additional comments (3)package.json (1)
모노레포의 패키지들 간에 일관된 빌드 설정을 공유할 수 있게 되어 유지보수성이 향상될 것으로 보입니다. packages/typography/package.json (2)
CSS 모듈 번들 이슈 수정을 위한 프리릴리즈 버전 업데이트가 semver 규칙을 잘 따르고 있습니다. Line range hint 현재 다음 스크립트를 실행하여 tsup 설정과 CSS 모듈 관련 설정을 확인해주세요: ✅ Verification successfulCSS 모듈 설정이 올바르게 구성되어 있습니다. Typography 컴포넌트의 CSS 모듈 처리가 다음과 같이 적절하게 설정되어 있음을 확인했습니다:
현재 설정으로 CSS 모듈이 올바르게 번들링되어 배포될 것으로 판단됩니다. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# tsup 설정 파일에서 CSS 모듈 관련 설정 확인
rg -A 10 "cssModules|local-css"
# 빌드 출력 디렉토리에서 CSS 파일 처리 방식 확인
fd -e css . dist/ --exec cat {} 2>/dev/null || echo "dist 디렉토리가 없거나 CSS 파일을 찾을 수 없습니다"
Length of output: 223 Script: #!/bin/bash
# Check the tsup configuration file content
cat tsup.config.ts
# Find any CSS imports or CSS module usage in the codebase
rg -g '*.{ts,tsx}' '\.css' -A 3
# Check package.json for CSS related configurations
cat packages/typography/package.json
Length of output: 5382 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -0,0 +1,20 @@ | |||
{ | |||
"mode": "pre", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-release 처음알았다...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 prerelease 모드 끄는거 깜빡했다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 이거 merge되기전에 꺼야하는거야 .. ? 미안 나 몰랐으....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
버그 수정 확인했습니다. 감사합니다 -
변경사항
local-css
를 주입하여 올바른 클래스네임을 생성하도록 변경시각자료
체크리스트
추가 논의사항
Summary by CodeRabbit
버전 업데이트
@sipe-team/typography
패키지 버전이0.0.2
에서0.0.3-next.0
으로 업데이트@sipe-team/badge
패키지 버전이0.0.1
에서0.0.2-next.0
으로 업데이트빌드 구성
tsup.config.ts
구성 파일 도입버그 수정