feat: eslint 설정 및 중복 import 방지 규칙 추가 (#64)

* feat: add eslint for additional rules * fix: pnpm exec
sipe-team · Jan 1, 2025 · 4656c79 · 4656c79
1 parent e6f76c0
commit 4656c79
Show file tree

Hide file tree

Showing 19 changed files with 618 additions and 253 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -24,7 +24,7 @@ jobs:
     - name: 의존성 설치
       run: pnpm install
     - name: 린트
-      run: pnpm --filter="...[origin/${{ github.base_ref }}]" lint
+      run: pnpm --filter="...[origin/${{ github.base_ref }}]" "/lint:*/"
     - name: 테스트
       run: pnpm --filter="...[origin/${{ github.base_ref }}]" test
     - name: 타입 체크

diff --git a/.templates/component/package.json b/.templates/component/package.json
@@ -14,13 +14,13 @@
     "build": "tsup",
     "build:storybook": "storybook build",
     "dev:storybook": "storybook dev -p 6006",
-    "lint": "biome lint .",
+    "lint:biome": "pnpm exec biome lint",
+    "lint:eslint": "pnpm exec eslint --flag unstable_ts_config",
     "test": "vitest",
     "typecheck": "tsc",
     "prepack": "pnpm run build"
   },
   "devDependencies": {
-    "@biomejs/biome": "catalog:",
     "@storybook/addon-essentials": "catalog:",
     "@storybook/addon-interactions": "catalog:",
     "@storybook/addon-links": "catalog:",

diff --git a/.vscode/extensions.json b/.vscode/extensions.json
@@ -1,3 +1,3 @@
 {
-  "recommendations": ["biomejs.biome"]
+  "recommendations": ["biomejs.biome", "dbaeumer.vscode-eslint"]
 }
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -3,5 +3,8 @@
   "editor.codeActionsOnSave": {
     "quickfix.biome": "explicit",
     "source.organizeImports.biome": "explicit"
+  },
+  "eslint.options": {
+    "flags": ["unstable_ts_config"]
   }
 }
diff --git a/eslint.config.ts b/eslint.config.ts
@@ -0,0 +1,17 @@
+import parser from '@typescript-eslint/parser';
+import type { Linter } from 'eslint';
+
+export default [
+  {
+    files: ['**/*.{js,ts,tsx}'],
+    languageOptions: {
+      parser,
+    },
+  },
+  { ignores: ['**/dist/'] },
+  {
+    rules: {
+      'no-duplicate-imports': 'error',
+    },
+  },
+] satisfies Linter.Config[];
diff --git a/package.json b/package.json
@@ -7,7 +7,7 @@
     "dev:storybook": "storybook dev -p 6006"
   },
   "devDependencies": {
-    "@biomejs/biome": "catalog:",
+    "@biomejs/biome": "^1.9.4",
     "@changesets/cli": "^2.27.9",
     "@storybook/addon-essentials": "catalog:",
     "@storybook/addon-interactions": "catalog:",
@@ -18,8 +18,10 @@
     "@storybook/test": "catalog:",
     "@tsconfig/strictest": "^2.0.5",
     "@types/node": "^22.8.1",
+    "@typescript-eslint/parser": "^8.19.0",
     "@vitest/coverage-v8": "2.1.4",
     "chromatic": "^11.19.0",
+    "eslint": "^9.17.0",
     "knip": "catalog:",
     "sanitize.css": "^13.0.0",
     "storybook": "catalog:",

diff --git a/packages/Input/package.json b/packages/Input/package.json
@@ -9,14 +9,13 @@
   },
   "type": "module",
   "exports": "./src/index.ts",
-  "files": [
-    "dist"
-  ],
+  "files": ["dist"],
   "scripts": {
     "build": "tsup",
     "build:storybook": "storybook build",
     "dev:storybook": "storybook dev -p 6006",
-    "lint": "biome lint .",
+    "lint:biome": "pnpm exec biome lint",
+    "lint:eslint": "pnpm exec eslint --flag unstable_ts_config",
     "test": "vitest",
     "typecheck": "tsc",
     "prepack": "pnpm run build"
@@ -26,7 +25,6 @@
     "classnames": "^2.5.1"
   },
   "devDependencies": {
-    "@biomejs/biome": "catalog:",
     "@storybook/addon-essentials": "catalog:",
     "@storybook/addon-interactions": "catalog:",
     "@storybook/addon-links": "catalog:",

diff --git a/packages/badge/package.json b/packages/badge/package.json
@@ -9,14 +9,13 @@
   },
   "type": "module",
   "exports": "./src/index.ts",
-  "files": [
-    "dist"
-  ],
+  "files": ["dist"],
   "scripts": {
     "build": "tsup",
     "build:storybook": "storybook build",
     "dev:storybook": "storybook dev -p 6006",
-    "lint": "biome lint .",
+    "lint:biome": "pnpm exec biome lint",
+    "lint:eslint": "pnpm exec eslint --flag unstable_ts_config",
     "test": "vitest",
     "typecheck": "tsc",
     "prepack": "pnpm run build"
@@ -26,7 +25,6 @@
     "clsx": "^2.1.1"
   },
   "devDependencies": {
-    "@biomejs/biome": "catalog:",
     "@storybook/addon-essentials": "catalog:",
     "@storybook/addon-interactions": "catalog:",
     "@storybook/addon-links": "catalog:",

diff --git a/packages/card/package.json b/packages/card/package.json
@@ -14,7 +14,8 @@
     "build": "tsup",
     "build:storybook": "storybook build",
     "dev:storybook": "storybook dev -p 6006",
-    "lint": "biome lint .",
+    "lint:biome": "pnpm exec biome lint",
+    "lint:eslint": "pnpm exec eslint --flag unstable_ts_config",
     "test": "vitest",
     "typecheck": "tsc",
     "prepack": "pnpm run build"
@@ -25,7 +26,6 @@
     "clsx": "^2.1.1"
   },
   "devDependencies": {
-    "@biomejs/biome": "catalog:",
     "@storybook/addon-essentials": "catalog:",
     "@storybook/addon-interactions": "catalog:",
     "@storybook/addon-links": "catalog:",

diff --git a/packages/divider/package.json b/packages/divider/package.json
@@ -9,20 +9,18 @@
   },
   "type": "module",
   "exports": "./src/index.ts",
-  "files": [
-    "dist"
-  ],
+  "files": ["dist"],
   "scripts": {
     "build": "tsup",
     "build:storybook": "storybook build",
     "dev:storybook": "storybook dev -p 6006",
-    "lint": "biome lint .",
+    "lint:biome": "pnpm exec biome lint",
+    "lint:eslint": "pnpm exec eslint --flag unstable_ts_config",
     "test": "vitest",
     "typecheck": "tsc",
     "prepack": "pnpm run build"
   },
   "devDependencies": {
-    "@biomejs/biome": "catalog:",
     "@sipe-team/typography": "workspace:*",
     "@storybook/addon-essentials": "catalog:",
     "@storybook/addon-interactions": "catalog:",

diff --git a/packages/radio-group/package.json b/packages/radio-group/package.json
@@ -9,20 +9,18 @@
   },
   "type": "module",
   "exports": "./src/index.ts",
-  "files": [
-    "dist"
-  ],
+  "files": ["dist"],
   "scripts": {
     "build": "tsup",
     "build:storybook": "storybook build",
     "dev:storybook": "storybook dev -p 6006",
-    "lint": "biome lint .",
+    "lint:biome": "pnpm exec biome lint",
+    "lint:eslint": "pnpm exec eslint --flag unstable_ts_config",
     "test": "vitest",
     "typecheck": "tsc",
     "prepack": "pnpm run build"
   },
   "devDependencies": {
-    "@biomejs/biome": "catalog:",
     "@storybook/addon-essentials": "catalog:",
     "@storybook/addon-interactions": "catalog:",
     "@storybook/addon-links": "catalog:",

diff --git a/packages/radio-group/src/RadioGroup.tsx b/packages/radio-group/src/RadioGroup.tsx
@@ -1,5 +1,4 @@
-import { createContext, useId } from 'react';
-import type { PropsWithChildren } from 'react';
+import { type PropsWithChildren, createContext, useId } from 'react';
 import styles from './RadioGroup.module.css';
 
 /**

diff --git a/packages/skeleton/package.json b/packages/skeleton/package.json
@@ -14,13 +14,13 @@
     "build": "tsup",
     "build:storybook": "storybook build",
     "dev:storybook": "storybook dev -p 6006",
-    "lint": "biome lint .",
+    "lint:biome": "pnpm exec biome lint",
+    "lint:eslint": "pnpm exec eslint --flag unstable_ts_config",
     "test": "vitest",
     "typecheck": "tsc",
     "prepack": "pnpm run build"
   },
   "devDependencies": {
-    "@biomejs/biome": "catalog:",
     "@faker-js/faker": "^9.2.0",
     "@storybook/addon-essentials": "catalog:",
     "@storybook/addon-interactions": "catalog:",

diff --git a/packages/switch/package.json b/packages/switch/package.json
@@ -9,20 +9,18 @@
   },
   "type": "module",
   "exports": "./src/index.ts",
-  "files": [
-    "dist"
-  ],
+  "files": ["dist"],
   "scripts": {
     "build": "tsup",
     "build:storybook": "storybook build",
     "dev:storybook": "storybook dev -p 6006",
-    "lint": "biome lint .",
+    "lint:biome": "pnpm exec biome lint",
+    "lint:eslint": "pnpm exec eslint --flag unstable_ts_config",
     "test": "vitest",
     "typecheck": "tsc",
     "prepack": "pnpm run build"
   },
   "devDependencies": {
-    "@biomejs/biome": "catalog:",
     "@faker-js/faker": "^9.2.0",
     "@storybook/addon-essentials": "catalog:",
     "@storybook/addon-interactions": "catalog:",

diff --git a/packages/tokens/package.json b/packages/tokens/package.json
@@ -9,19 +9,17 @@
   },
   "type": "module",
   "exports": "./src/index.ts",
-  "files": [
-    "dist"
-  ],
+  "files": ["dist"],
   "scripts": {
     "build": "tsup",
     "build:storybook": "storybook build",
     "dev:storybook": "storybook dev -p 6006",
-    "lint": "biome lint .",
+    "lint:biome": "pnpm exec biome lint",
+    "lint:eslint": "pnpm exec eslint --flag unstable_ts_config",
     "typecheck": "tsc",
     "prepack": "pnpm run build"
   },
   "devDependencies": {
-    "@biomejs/biome": "catalog:",
     "@faker-js/faker": "^9.2.0",
     "@sipe-team/typography": "workspace:*",
     "@storybook/addon-essentials": "catalog:",

diff --git a/packages/tooltip/package.json b/packages/tooltip/package.json
@@ -9,14 +9,13 @@
   },
   "type": "module",
   "exports": "./src/index.ts",
-  "files": [
-    "dist"
-  ],
+  "files": ["dist"],
   "scripts": {
     "build": "tsup",
     "build:storybook": "storybook build",
     "dev:storybook": "storybook dev -p 6006",
-    "lint": "biome lint .",
+    "lint:biome": "pnpm exec biome lint",
+    "lint:eslint": "pnpm exec eslint --flag unstable_ts_config",
     "test": "vitest",
     "typecheck": "tsc",
     "prepack": "pnpm run build"
@@ -29,7 +28,6 @@
     "react-dom": "^18.3.1"
   },
   "devDependencies": {
-    "@biomejs/biome": "catalog:",
     "@faker-js/faker": "^9.2.0",
     "@storybook/addon-essentials": "catalog:",
     "@storybook/addon-interactions": "catalog:",

diff --git a/packages/typography/package.json b/packages/typography/package.json
@@ -14,7 +14,8 @@
     "build": "tsup",
     "build:storybook": "storybook build",
     "dev:storybook": "storybook dev -p 6006",
-    "lint": "biome lint .",
+    "lint:biome": "pnpm exec biome lint",
+    "lint:eslint": "pnpm exec eslint --flag unstable_ts_config",
     "test": "vitest",
     "typecheck": "tsc",
     "prepack": "pnpm run build"
@@ -25,7 +26,6 @@
     "clsx": "^2.1.1"
   },
   "devDependencies": {
-    "@biomejs/biome": "catalog:",
     "@faker-js/faker": "^9.2.0",
     "@storybook/addon-essentials": "catalog:",
     "@storybook/addon-interactions": "catalog:",