Add --address, bind to specific address #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
uhliksk
commented
Aug 6, 2020
uhliksk
commented
- Fix DNS requests being received but not answered with a corrrect query response #83 (will reply from same address as provided)
- Fix Does not work on ipv4 address #59 (will work if you bind to specific IPv4 address)
- Fix Does not listen port 53 #51 (will work with systemd-resolved service if you bind to specific address)
|
ACK bf40486 |
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 29, 2021
Summary: Backport of sipa/bitcoin-seeder#84 Some configurations need to bind a specific address. See issues referenced in the original pull request. I had to modify the original pull request to match the ABC code base. Test Plan: Test cases: ./bitcoin-seeder -host=localhost -ns=localhost [email protected] -port=5555 ./bitcoin-seeder -host=localhost -ns=localhost [email protected] -port=5555 -address=127.0.0.1 ./bitcoin-seeder -host=localhost -ns=localhost [email protected] -port=5555 -address=::1 Results of `sudo netstat -pln | grep 5555` for each test case: udp6 0 0 :::5555 :::* 18998/./bitcoin-see udp6 0 0 127.0.0.1:5555 :::* 19121/./bitcoin-see udp6 0 0 ::1:5555 :::* 19361/./bitcoin-see Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D10186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.