Skip to content

Commit

Permalink
test: run on y24 lts (#272)
Browse files Browse the repository at this point in the history
  • Loading branch information
simPod authored Jan 15, 2025
1 parent b680a8d commit 126dfaa
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 13 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ jobs:
- "23.7"
- "23.8"
- "23.9"
- "24.3"
- "24.8"
dependency-versions:
- "highest"
env:
Expand Down
34 changes: 21 additions & 13 deletions tests/Param/ParamValueConverterRegistryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ final class ParamValueConverterRegistryTest extends TestCaseBase
use WithClient;

private const VersionIntervalJson = 2301;
private const VersionLineString = 2408;
private const VersionVariant = 2403;

/** @var array<string> */
private static array $types = [];
Expand Down Expand Up @@ -181,7 +183,10 @@ public static function providerConvert(): Generator
yield 'Bool' => ['Bool', true, 'true'];

yield 'Dynamic' => ['Bool', true, 'true'];
yield 'Variant' => ['Variant(String, Int8)', 'test', 'test'];

if (ClickHouseVersion::get() >= self::VersionVariant) {
yield 'Variant' => ['Variant(String, Int8)', 'test', 'test'];
}

yield 'Nullable' => ['Nullable(String)', 'foo', 'foo'];
yield 'LowCardinality' => ['LowCardinality(String)', 'foo', 'foo'];
Expand Down Expand Up @@ -239,19 +244,22 @@ public static function providerConvert(): Generator
yield 'Point (array)' => ['Point', [1, 2], '(1,2)'];
yield 'Ring' => ['Ring', '[(1,2),(3,4)]', '[(1,2),(3,4)]'];
yield 'Ring (array)' => ['Ring', [[1, 2], [3, 4]], '[(1,2),(3,4)]'];
yield 'LineString' => ['LineString', '[(1,2),(3,4)]', '[(1,2),(3,4)]'];
yield 'LineString (array)' => ['LineString', [[1, 2], [3, 4]], '[(1,2),(3,4)]'];
yield 'MultiLineString' => [
'MultiLineString',
'[[(1,2),(3,4)],[(5,6),(7,8)]]',
'[[(1,2),(3,4)],[(5,6),(7,8)]]',
];

yield 'MultiLineString (array)' => [
'MultiLineString',
[[[1, 2], [3, 4]], [[5, 6], [7, 8]]],
'[[(1,2),(3,4)],[(5,6),(7,8)]]',
];
if (ClickHouseVersion::get() >= self::VersionLineString) {
yield 'LineString' => ['LineString', '[(1,2),(3,4)]', '[(1,2),(3,4)]'];
yield 'LineString (array)' => ['LineString', [[1, 2], [3, 4]], '[(1,2),(3,4)]'];
yield 'MultiLineString' => [
'MultiLineString',
'[[(1,2),(3,4)],[(5,6),(7,8)]]',
'[[(1,2),(3,4)],[(5,6),(7,8)]]',
];

yield 'MultiLineString (array)' => [
'MultiLineString',
[[[1, 2], [3, 4]], [[5, 6], [7, 8]]],
'[[(1,2),(3,4)],[(5,6),(7,8)]]',
];
}

yield 'Polygon' => ['Polygon', '[[(1,2),(3,4)],[(5,6),(7,8)]]', '[[(1,2),(3,4)],[(5,6),(7,8)]]'];
yield 'Polygon (array)' => ['Polygon', [[[1, 2], [3, 4]], [[5, 6], [7, 8]]], '[[(1,2),(3,4)],[(5,6),(7,8)]]'];
Expand Down

0 comments on commit 126dfaa

Please sign in to comment.