Skip to content

Commit

Permalink
Bump minimum core version requirement to 4.3
Browse files Browse the repository at this point in the history
  • Loading branch information
robbieaverill committed Jul 26, 2018
1 parent c18690b commit 73eb3c1
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
"issues": "http://github.com/silverstripe/silverstripe-tagfield/issues"
},
"require": {
"silverstripe/framework": "^4.0",
"silverstripe/versioned": "^1.0"
"silverstripe/framework": "^4.3",
"silverstripe/versioned": "^1.3"
},
"require-dev": {
"phpunit/phpunit": "^5.7",
Expand All @@ -33,9 +33,6 @@
}
},
"extra": {
"branch-alias": {
"dev-master": "2.x-dev"
},
"expose": [
"client/dist"
]
Expand Down

4 comments on commit 73eb3c1

@tractorcow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is on this module that doesn't work in 4.2? I have a 4.2 project I've tried to install this on and getting it rejected.

@robbieaverill
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered this when I looked back myself, I wish I'd clarified why when I did it =D

@robbieaverill
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was an incompatibility with either Bootstrap or React in SS <4.3

@tractorcow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thank you :D

Please sign in to comment.