Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try from option and enum #8

Merged
merged 11 commits into from
Jul 9, 2024
Merged

Conversation

syyyr
Copy link
Contributor

@syyyr syyyr commented Jul 8, 2024

No description provided.

syyyr added 2 commits July 8, 2024 19:33
I need the previous version, because I don't want to put None Options into the
map.

This reverts commit 8bdcf65.
@syyyr syyyr changed the title Try from option Try from option and enum Jul 8, 2024
libshvproto-macros/src/lib.rs Outdated Show resolved Hide resolved
libshvproto-macros/src/lib.rs Outdated Show resolved Hide resolved
libshvproto-macros/src/lib.rs Outdated Show resolved Hide resolved
@syyyr syyyr force-pushed the try_from_option branch from 6b06125 to 2786ebe Compare July 9, 2024 09:10
@syyyr syyyr force-pushed the try_from_option branch 3 times, most recently from 3db5b18 to a127222 Compare July 9, 2024 12:39
Copy link
Contributor

@j4r0u53k j4r0u53k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@syyyr syyyr marked this pull request as ready for review July 9, 2024 13:13
@fvacek fvacek merged commit 1514c97 into silicon-heaven:master Jul 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants