Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win build to create cp2cp during CI #30

Merged
merged 3 commits into from
Dec 22, 2024
Merged

Win build to create cp2cp during CI #30

merged 3 commits into from
Dec 22, 2024

Conversation

fvacek
Copy link
Contributor

@fvacek fvacek commented Dec 20, 2024

No description provided.

Copy link
Contributor

@syyyr syyyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also suggest uploading the artifacts as a nightly release as we do in shvspy here

Otherwise, I like it, very nice.

.github/workflows/rust.yml Outdated Show resolved Hide resolved
.github/workflows/rust.yml Outdated Show resolved Hide resolved
.github/workflows/rust.yml Outdated Show resolved Hide resolved
.github/workflows/rust.yml Outdated Show resolved Hide resolved
.github/workflows/rust.yml Show resolved Hide resolved
.github/workflows/rust.yml Outdated Show resolved Hide resolved
.github/workflows/rust.yml Outdated Show resolved Hide resolved
@syyyr
Copy link
Contributor

syyyr commented Dec 21, 2024

fyi: the build fails because you have to (single) quote the github.workspace thingy

@fvacek
Copy link
Contributor Author

fvacek commented Dec 22, 2024

I'd also suggest uploading the artifacts as a nightly release as we do in shvspy here

Otherwise, I like it, very nice.

Yes, to make release would be nice. I would better prefer to do it in separate PR.

@fvacek fvacek force-pushed the win-build branch 2 times, most recently from c83ef4b to e2a4778 Compare December 22, 2024 18:56
@fvacek fvacek merged commit 9508e48 into master Dec 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants