Implement TryFrom on RpcValue #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying type is just i64.
Implements TryFrom<&RpcValue> and TryFrom<RpcValue> for various basic types and their references. TryFrom<&RpcValue> would be useful e.g. for RPC requests params parsing, where `RpcMessge::param()` returns `Option<&RpcValue>`. TryFrom<RpcValue> can provide more efficient implementation for larger datatypes (Blob, List, Map, String), where the returned value is just moved out of the underlying Box without cloning.
j4r0u53k
force-pushed
the
try-from-rpcvalue
branch
from
8195050 to
819e71b
Compare
New features: - Implement Copy trait for Decimal - Implement `TryFrom<RpcValue>` and `TryFrom<&RpcValue>` for basic types and their references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
TryFrom<&RpcValue>andTryFrom<RpcValue>for variousbasic types and their references.
TryFrom<&RpcValue>would be useful e.g. for RPC requests paramsparsing, where
RpcMessge::param()returnsOption<&RpcValue>.TryFrom<RpcValue>can provide more efficient implementation forlarger datatypes (Blob, List, Map, String), where the returned
value is just moved out of the underlying Box without cloning.
Crates using this library can further add any implementations of
TryFrom<RpcValue>orTryFrom<&RpcValue>for their own typesand get a uniform way to perform all types conversions from
RpcValue.