Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWAT-8663 gateway - add signalfx exporter to traces pipeline to enable correlation #1607

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

dloucasfx
Copy link
Contributor

Description:
In an Agent -> GW configuration, the traces correlations happen in 2 different places

  1. host.name correlation occurs at the agent/collector running on the same host as the instrumented app. (no issue here)
  2. k8s metadata enrichment ex: k8s.pod.uid occurs at the GW (k8sattributes processor on the agent is configured with passthrough set to true) . However, the GW traces pipelines is not configured with the signalfx exporter, ie: no correlation will be attempted .

This PR simply adds the signalfx exporter to the traces pipeline to enable correlation at the GW level.

@dloucasfx dloucasfx requested review from a team as code owners January 10, 2025 20:26
Copy link
Contributor

github-actions bot commented Jan 10, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@dloucasfx
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@dloucasfx
Copy link
Contributor Author

recheck

srv-gh-o11y-gdi-cla added a commit to splunk/cla-agreement that referenced this pull request Jan 10, 2025
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax merged commit b12eb4f into main Jan 10, 2025
63 of 64 checks passed
@dmitryax dmitryax deleted the SWAT-8663 branch January 10, 2025 21:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants