Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it so the default tolerations used to deploy the agent collector account for k8s distribution #1562

Merged
merged 6 commits into from
Dec 11, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .chloggen/enhance-agent-daemonset-toleration.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement
# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
component: agent
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Make it so the default tolerations used to deploy the agent collector account for k8s distribution
# One or more tracking issues related to the change
issues: [1562]
# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: OpenShift infra nodes and Azure system nodes will now be monitored by the agent by default
atoulme marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
initContainers:
- name: migrate-checkpoint
image: quay.io/signalfx/splunk-otel-collector:0.113.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
initContainers:
- name: migrate-checkpoint
image: quay.io/signalfx/splunk-otel-collector:0.113.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
containers:
- name: otel-collector
command:
Expand Down
11 changes: 6 additions & 5 deletions examples/add-sampler/rendered_manifests/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
containers:
- name: otel-collector
command:
Expand Down
11 changes: 6 additions & 5 deletions examples/autodetect-istio/rendered_manifests/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
initContainers:
- name: migrate-checkpoint
image: quay.io/signalfx/splunk-otel-collector:0.113.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
containers:
- name: otel-collector
command:
Expand Down
11 changes: 6 additions & 5 deletions examples/collector-all-modes/rendered_manifests/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
containers:
- name: otel-collector
command:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
containers:
- name: otel-collector
command:
Expand Down
11 changes: 6 additions & 5 deletions examples/crio-logging/rendered_manifests/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
containers:
- name: otel-collector
command:
Expand Down
11 changes: 6 additions & 5 deletions examples/default/rendered_manifests/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
containers:
- name: otel-collector
command:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
initContainers:
- name: migrate-checkpoint
image: quay.io/signalfx/splunk-otel-collector:0.113.0
Expand Down
11 changes: 6 additions & 5 deletions examples/discovery-mode/rendered_manifests/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
containers:
- name: otel-collector
command:
Expand Down
14 changes: 9 additions & 5 deletions examples/distribution-aks/rendered_manifests/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,15 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
- key: kubernetes.io/system-node
effect: NoSchedule
operator: Exists
containers:
- name: otel-collector
command:
Expand Down
11 changes: 6 additions & 5 deletions examples/distribution-eks/rendered_manifests/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
containers:
- name: otel-collector
command:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
containers:
- name: otel-collector
command:
Expand Down
11 changes: 6 additions & 5 deletions examples/distribution-gke/rendered_manifests/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
containers:
- name: otel-collector
command:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,15 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/infra
effect: NoSchedule
operator: Exists
containers:
- name: otel-collector
command:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
initContainers:
- name: migrate-checkpoint
image: quay.io/signalfx/splunk-otel-collector:0.113.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
initContainers:
- name: migrate-checkpoint
image: quay.io/signalfx/splunk-otel-collector:0.113.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
containers:
- name: otel-collector
command:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ spec:
nodeSelector:
kubernetes.io/os: linux
tolerations:

- effect: NoSchedule
key: node-role.kubernetes.io/master
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
- key: node-role.kubernetes.io/master
effect: NoSchedule
operator: Equal
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
operator: Equal
containers:
- name: otel-collector
command:
Expand Down
Loading
Loading