Add optional annotations to secrets

signalfx · Jan 9, 2025 · 3fdd71e · 3fdd71e
1 parent b49ef63
commit 3fdd71e
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 0 deletions.
diff --git a/helm-charts/splunk-otel-collector/templates/secret-etcd.yaml b/helm-charts/splunk-otel-collector/templates/secret-etcd.yaml
@@ -10,6 +10,10 @@ metadata:
     chart: {{ template "splunk-otel-collector.chart" . }}
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}
+  {{- if .Values.agent.controlPlaneMetrics.etcd.secret.annotations }}
+  annotations:
+    {{- toYaml .Values.agent.controlPlaneMetrics.etcd.secret.annotations | nindent 4 }}
+  {{- end }}
 type: Opaque
 data:
   {{- with .Values.agent.controlPlaneMetrics.etcd.secret.clientCert }}

diff --git a/helm-charts/splunk-otel-collector/templates/secret-splunk.yaml b/helm-charts/splunk-otel-collector/templates/secret-splunk.yaml
@@ -10,6 +10,10 @@ metadata:
     chart: {{ template "splunk-otel-collector.chart" . }}
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}
+  {{- if .Values.secret.annotations }}
+  annotations:
+    {{- toYaml .Values.secret.annotations | nindent 4 }}
+  {{- end }}
 type: Opaque
 data:
   {{- if (eq (include "splunk-otel-collector.splunkO11yEnabled" .) "true") }}

diff --git a/helm-charts/splunk-otel-collector/values.schema.json b/helm-charts/splunk-otel-collector/values.schema.json
@@ -425,6 +425,9 @@
                     },
                     "caFile": {
                       "type": "string"
+                    },
+                    "annotations": {
+                      "type": "object"
                     }
                   }
                 },
@@ -1188,6 +1191,9 @@
         },
         "validateSecret": {
           "type": "boolean"
+        },
+        "annotations": {
+          "type": "object"
         }
       }
     },

diff --git a/helm-charts/splunk-otel-collector/values.yaml b/helm-charts/splunk-otel-collector/values.yaml
@@ -320,6 +320,8 @@ agent:
         # NOTE: The content of the file itself should be used here, not the file path.
         #       The file will be stored as a secret in kubernetes.
         caFile: ""
+        # Secret annotations
+        annotations: {}
       # Specifies whether the etcd's TLS cert will be verified. If set to false, a CA certificate must be made
       # available as part of the etcd secret to verify the TLS cert with.
       skipVerify: true
@@ -1010,6 +1012,8 @@ secret:
   name: ""
   # Specifies whether secret provided by user should be validated.
   validateSecret: true
+  # Secret annotations
+  annotations: {}
 
 # The tolerations for deploying the agent collector daemonset. By default, it targets control-plane, worker,
 # and k8s distribution-specific nodes (infrastructure or system) to ensure logs and metrics collection from nodes.