Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support WG over GRPC in Omni #91

Merged
merged 1 commit into from
Apr 10, 2024
Merged

feat: support WG over GRPC in Omni #91

merged 1 commit into from
Apr 10, 2024

Conversation

DmitriyMV
Copy link
Member

This PR adds the support for WG over GRPC. New field in VirtualAddrport in SiderolinkSpec should allow for both setting the virtual addr and loading it after the Omni restart.

@DmitriyMV DmitriyMV linked an issue Mar 28, 2024 that may be closed by this pull request
bring SideroLink over GRPC to Omni #78
Closed
@DmitriyMV DmitriyMV self-assigned this Apr 1, 2024
@DmitriyMV
chore: support WG over GRPC in Omni
d3e3eef 
This PR adds the support for WG over GRPC. New field `VirtualAddrport`
in `SiderolinkSpec` should allow for both
setting the virtual addr and loading it after the Omni restart.

Signed-off-by: Dmitriy Matrenichev <[email protected]>
@DmitriyMV DmitriyMV added the integration/e2e-short Triggers all e2e short tests for Omni label Apr 10, 2024
@andrewrynhard
Copy link
Member

A very small nit and will come off as annoying I am sure but I would argue this is a feat. The idea behind keeping commits accurate is that users and support can look at a CHANGELOG and quickly identify what changed. Features are the most common thing people want to know. A chore is CI related and something people skip.

@DmitriyMV
Copy link
Member Author

/m

@talos-bot talos-bot merged commit d3e3eef into main Apr 10, 2024
18 checks passed
@talos-bot talos-bot deleted the wg-over-grpc branch April 10, 2024 17:05
@DmitriyMV DmitriyMV changed the title chore: support WG over GRPC in Omni feat: support WG over GRPC in Omni Apr 10, 2024
@DmitriyMV
Copy link
Member Author

A very small nit and will come off as annoying I am sure but I would argue this is a feat. The idea behind keeping commits accurate is that users and support can look at a CHANGELOG and quickly identify what changed. Features are the most common thing people want to know. A chore is CI related and something people skip.

Not at all. But I noticed that too late when I already pressed "/m". :) But I renamed the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unix4ever Unix4ever Unix4ever approved these changes

Assignees

@DmitriyMV DmitriyMV

Labels
integration/e2e-short Triggers all e2e short tests for Omni
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bring SideroLink over GRPC to Omni
4 participants
@DmitriyMV @andrewrynhard @Unix4ever @talos-bot