feat: implement power states as machine stage events #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new component to watch infra.MachineStatus resources to produce complementary "synthetic" machine events for "powering on" and "powered off" stages. Change the logic in `MachineStatusSnapshot` and `ClusterMachineStatus` controllers to take these changes into account. This is required to display the correct status for the machines that are powered on/off by the infra providers. Signed-off-by: Utku Ozdemir <[email protected]>
Unix4ever
reviewed
Jan 16, 2025
| if err != nil { | ||
| return fmt.Errorf("failed to read resource from the event: %w", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we might need to ignore Destroyed events here.
Or make it the opposite: only Created and Updated should be handled.
Unix4ever
reviewed
Jan 16, 2025
| @@ -32,17 +32,19 @@ type MachineStatusSnapshotController struct { | |||
| runner *task.Runner[snapshot.InfoChan, snapshot.CollectTaskSpec] | |||
| notifyCh chan *omni.MachineStatusSnapshot | |||
| siderolinkCh <-chan *omni.MachineStatusSnapshot | |||
| powerStageCh <-chan *omni.MachineStatusSnapshot | |||
There was a problem hiding this comment.
I wonder if we could reuse siderolinkCh here instead of creating a new channel.
There was a problem hiding this comment.
I just thought this would be clearer, as they don't come from SideroLink. I think it is more obvious this way that there are 2 different sources. Wdyt?
There was a problem hiding this comment.
or we could rename siderolinkCh to the eventsCh, as they are kinda similar.
I'm torn now :D
There was a problem hiding this comment.
I guess we can keep the two channels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new component to watch infra.MachineStatus resources to produce complementary "synthetic" machine events for "powering on" and "powered off" stages.
Change the logic in
MachineStatusSnapshotandClusterMachineStatuscontrollers to take these changes into account.This is required to display the correct status for the machines that are powered on/off by the infra providers.