feat: sync infra machine labels onto the machine status #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy the labels set on infra.MachineStatus to omni.MachineStatus resources. Introduce a special prefix for the labels set by infra providers, so that they can keep track and synchronize the labels as needed. Signed-off-by: Utku Ozdemir <[email protected]>
smira
approved these changes
Jan 8, 2025
|
@Unix4ever do you think we need a makeup for this in the UI? (not blocking this PR, we can address separately if we need. Posting this so it doesn't get lost.) 
|
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the labels set on infra.MachineStatus to omni.MachineStatus resources.
Introduce a special prefix for the labels set by infra providers, so that they can keep track and synchronize the labels as needed.
Related to/depends on siderolabs/omni-infra-provider-bare-metal#16.