Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compute schematic id only from the extensions #74

Merged
merged 1 commit into from
Mar 22, 2024
Merged

feat: compute schematic id only from the extensions #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 65 additions & 63 deletions client/api/omni/specs/omni.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions client/api/omni/specs/omni.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,17 @@ message MachineStatusSpec {

message Schematic {
// Id is the image factory schematic id used for the image generation.
//
// This must be be plain id computed solely from the system extensions, not including the kernel command line arguments, META content etc.
string id = 1;

// Invalid marks the machine as having extensions installed bypassing image factory.
// Which makes it impossible to detect schematic id and manage the image generation
// using image factory.
bool invalid = 2;

// Extensions is the list of extensions installed on the machine.
repeated string extensions = 3;
}

message MaintenanceConfig {
Expand Down Expand Up @@ -907,7 +912,7 @@ message ImagePullStatusSpec {
// SchematicSpec keeps all schematics generated by Omni.
// For each schematic it keeps information about the list of extensions.
message SchematicSpec {
repeated string extensions = 1;
reserved 1;
}

// TalosExtensionsSpec represents all available extensions for a particular Talos version.
Expand Down Expand Up @@ -937,4 +942,4 @@ message SchematicConfigurationSpec {
string schematic_id = 1;

Target target = 2;
}
}
Loading
Loading