fix: prevent link and clustermachine deletion from getting stuck #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
reviewed
Apr 3, 2024
smira
approved these changes
Apr 3, 2024
Yes, that's really confusing, but it happened and we need to recover from it atm. |
This PR contains fixes for the following issues: - When a `Link` resource was deleted, `MachineCleanupController` was unable to remove finalizers on the `MachineSetNode` resource, as it did not pass the correct owner `""` when calling `Teardown`. - `ClusterMachineStatusController` not handling the cases where the matching `Machine` might be missing. - `MachineSetController` not handling the cases where the `Machine` resource was missing for any of the `MachineSetNode`s that were tearing down. The latter two fixes prevent clusters from getting stuck if they are in a state where there is a missing machine in their machine sets. Closes #100, closes #97. Signed-off-by: Utku Ozdemir <[email protected]>
utkuozdemir
force-pushed
the
fix-stuck-clustermachine-deletion
branch
from
752f03b to
5dc2eaa
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fixes for the following issues:
Linkresource was deleted,MachineCleanupControllerwas unable to remove finalizers on theMachineSetNoderesource, as it did not pass the correct owner""when callingTeardown.ClusterMachineStatusControllernot handling the cases where the matchingMachinemight be missing.MachineSetControllernot handling the cases where theMachineresource was missing for any of theMachineSetNodes that were tearing down.The latter two fixes prevent clusters from getting stuck if they are in a state where there is a missing machine in their machine sets.
Closes #100, closes #97.