Skip to content

Commit

Permalink
fix: properly handle upgrades for the machines with invalid schematics
Browse files Browse the repository at this point in the history
Simple fix to not skip updating Talos if the machine schematic is empty.

Signed-off-by: Artem Chernyshev <[email protected]>
  • Loading branch information
Unix4ever committed Mar 18, 2024
1 parent 4db7630 commit 2d1b776
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ func NewClusterMachineConfigStatusController() *ClusterMachineConfigStatusContro
machineStatus.TypedSpec().Value.Schematic.Id != expectedSchematic

// don't run the upgrade check if the running version and expected versions match
if versionMismatch && talosVersion.TypedSpec().Value.TalosVersion != "" && talosVersion.TypedSpec().Value.SchematicId != "" {
if versionMismatch && talosVersion.TypedSpec().Value.TalosVersion != "" {
inSync, err := handler.syncTalosVersionAndSchematic(ctx, configStatus, machineStatus, machineConfig, statusSnapshot, talosVersion)
if err != nil {
return err
Expand Down

0 comments on commit 2d1b776

Please sign in to comment.