Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: Svelte 5 #62

Merged
merged 57 commits into from
Dec 4, 2024
Merged

next: Svelte 5 #62

merged 57 commits into from
Dec 4, 2024

Conversation

shyakadavis
Copy link
Owner

No description provided.

Copy link
Contributor

github-actions bot commented Sep 30, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
geist ✅ Ready (View Log) Visit Preview 44c3871

@shyakadavis
Copy link
Owner Author

shyakadavis commented Dec 4, 2024

Had forgotten about this one.
@ieedan any thoughts? I know it's large P.R, so it's cool if you don't have the time right now; wanted to ask for some input about the components themselves.

@ieedan
Copy link
Contributor

ieedan commented Dec 4, 2024

Yeah I am looking right now!

image
Glad you got this one figured out it looks sick

@ieedan
Copy link
Contributor

ieedan commented Dec 4, 2024

I think vercel likes to move the bar a lot so we can't expect everything to match perfectly but there were a few things I noticed (not done so I'll update this list)

  • Avatar placeholder is different from original
  • Our Search component uses an X instead of Esc
  • KBD component shouldn't use serif as the font vercel just uses Geist here
  • Menu component should be aligned start
  • Filled variants of note should have the same color for border and background
  • Not sure if Vercel changed or we did but they call the shadcn-ui default Tabs component switch https://vercel.com/geist/switch (Rename Switch -> Toggle)
  • Tabs is missing the bottom border
  • I like the window component but they seemed to have dropped it
  • Progress colors got inverted
    image

@ieedan
Copy link
Contributor

ieedan commented Dec 4, 2024

My work laptop seems to agree that this is a very large PR and it really doesn't like me trying to do anything though the website!

@ieedan
Copy link
Contributor

ieedan commented Dec 4, 2024

That's my quick review. Overall I think everything works pretty good with a few exceptions noted above! I didn't put every difference but instead just the glaringly obvious stuff I think everyone will notice or things that aren't the intended behavior.

@ieedan
Copy link
Contributor

ieedan commented Dec 4, 2024

Also if you want people to be able to add these components kinda shadcn-style without having to copy the code themselves you can probably use the project I am working on called jsrepo could be cool cause then it can be almost a drop in replacement for shadcn-svelte with the Vercel styling.

@shyakadavis
Copy link
Owner Author

shyakadavis commented Dec 4, 2024

Thank you very much, @ieedan Caught a bunch of stuff I had missed.
I'm holding off on renaming the components just yet, but will eventually do.
Also, Vercel changed a bunch of stuff, for sure. Saw even new components since my last visit.

As for jsrepo been meaning to try it out (subbed to your channel last week 😁). We could also add a note in this repo's readme.

@ieedan
Copy link
Contributor

ieedan commented Dec 4, 2024

Yeah I don't think we need to add anything on the site like jsrepo add <component> but a note in the README would work. Anyone using this will have to visit the GH anyways.

It does require (minimal) configuration so if you would prefer me to open a PR for it I can!

@shyakadavis
Copy link
Owner Author

if you would prefer me to open a PR for it I can!

Please do. Let merge this first.

@shyakadavis shyakadavis merged commit 1cf5aa2 into main Dec 4, 2024
4 checks passed
@shyakadavis shyakadavis deleted the next branch December 4, 2024 16:40
@ieedan
Copy link
Contributor

ieedan commented Dec 4, 2024

You forgot the progress bar lol

@shyakadavis
Copy link
Owner Author

You forgot the progress bar lol

Snap. 😅 Will open a follow-up later tonight, if not, tomorrow. (Bout to head home right now)

@ieedan
Copy link
Contributor

ieedan commented Dec 4, 2024

NP I should be able to open one for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants