-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next: Svelte 5 #62
next: Svelte 5 #62
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Had forgotten about this one. |
I think vercel likes to move the bar a lot so we can't expect everything to match perfectly but there were a few things I noticed (not done so I'll update this list)
|
My work laptop seems to agree that this is a very large PR and it really doesn't like me trying to do anything though the website! |
That's my quick review. Overall I think everything works pretty good with a few exceptions noted above! I didn't put every difference but instead just the glaringly obvious stuff I think everyone will notice or things that aren't the intended behavior. |
Also if you want people to be able to add these components kinda shadcn-style without having to copy the code themselves you can probably use the project I am working on called jsrepo could be cool cause then it can be almost a drop in replacement for |
Thank you very much, @ieedan Caught a bunch of stuff I had missed. As for |
Yeah I don't think we need to add anything on the site like It does require (minimal) configuration so if you would prefer me to open a PR for it I can! |
Please do. Let merge this first. |
You forgot the progress bar lol |
Snap. 😅 Will open a follow-up later tonight, if not, tomorrow. (Bout to head home right now) |
NP I should be able to open one for it! |
No description provided.