Add a find_work_files hook for perforce work flows #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 10, 2019
| environment.work_template, | ||
| publish_items = self._process_publish_files(sg_publishes, | ||
| environment.publish_template, | ||
| environment.work_template, |
There was a problem hiding this comment.
continuation line under-indented for visual indent
| environment.publish_template, | ||
| environment.work_template, | ||
| publish_items = self._process_publish_files(sg_publishes, | ||
| environment.publish_template, |
There was a problem hiding this comment.
continuation line under-indented for visual indent
| environment.valid_file_extensions) | ||
| return {"sg_publishes":filtered_publishes} | ||
| return {"sg_publishes":filtered_publishes} |
| @@ -371,7 +371,7 @@ def _process_publish_files(self, sg_publishes, publish_template, work_template, | |||
| # add new file item for this publish. Note that we also keep track of the | |||
| # work path even though we don't know if this publish has a corresponding | |||
| # work file. | |||
| files[(file_key, file_details["version"])] = {"key":file_key, | |||
| files[(file_key, file_details["version"])] = {"key":file_key, | |||
| publish_template, | ||
| work_template, | ||
| context, | ||
| name_map, |
There was a problem hiding this comment.
continuation line under-indented for visual indent
| work_template, | ||
| context, | ||
| name_map, | ||
| version_compare_ignore_fields, |
There was a problem hiding this comment.
continuation line under-indented for visual indent
| work_file_item_details = self._process_work_files(filtered_work_files, | ||
| work_template, | ||
| context, | ||
| name_map, |
There was a problem hiding this comment.
continuation line under-indented for visual indent
| version_compare_ignore_fields, | ||
| work_file_item_details = self._process_work_files(filtered_work_files, | ||
| work_template, | ||
| context, |
There was a problem hiding this comment.
continuation line under-indented for visual indent
| name_map, | ||
| version_compare_ignore_fields, | ||
| work_file_item_details = self._process_work_files(filtered_work_files, | ||
| work_template, |
There was a problem hiding this comment.
continuation line under-indented for visual indent
| and pre_v_str[-1] in delims_str | ||
|
|
||
| if (pre_v_str and post_v_str | ||
| and pre_v_str[-1] in delims_str |
BoubQC
suggested changes
Feb 13, 2020
hooks/find_work_files.py
Outdated
| HookClass = sgtk.get_hook_baseclass() | ||
|
|
||
|
|
||
| class FilterWorkFiles(HookClass): |
hooks/find_work_files.py
Outdated
|
|
||
| class FilterWorkFiles(HookClass): | ||
| """ | ||
| Hook that can be used to filter the list of work files found by the app for the current |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| aren't synced on the users machine yet. | ||
| """ | ||
|
|
||
| def execute(self, work_files_paths, work_template, work_fields, skip_fields, skip_missing_optional_keys=True, **kwargs): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a hook to allow finding additional workfiles.
This is handy in a perforce setup where all the workfiles might not have been synced to the users machine when it runs the _find_workfiles method.