Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-410 - Addition of custom templates via app #1173

Merged
merged 11 commits into from
Nov 10, 2023
Merged

Conversation

sushmangupta
Copy link
Collaborator

No description provided.

guides/plugins/apps/customize-templates.md Outdated Show resolved Hide resolved
guides/plugins/apps/customize-templates.md Outdated Show resolved Hide resolved
@sushmangupta sushmangupta changed the title DX-410 - Addition of custom templates via app WIP DX-410 - Addition of custom templates via app Nov 8, 2023
@sushmangupta sushmangupta marked this pull request as draft November 8, 2023 09:42
@sushmangupta sushmangupta marked this pull request as ready for review November 10, 2023 10:09
@sushmangupta sushmangupta changed the title WIP DX-410 - Addition of custom templates via app DX-410 - Addition of custom templates via app Nov 10, 2023
@sushmangupta
Copy link
Collaborator Author

@Isengo1989 , FYI - 'FroshDevelopmentHelper' also work for apps

Copy link
Collaborator

@Isengo1989 Isengo1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sushmangupta thx for the PR. I added some grammar fixes that we might also want to apply on the plugins docs.

guides/plugins/apps/storefront/customize-templates.md Outdated Show resolved Hide resolved
guides/plugins/apps/storefront/customize-templates.md Outdated Show resolved Hide resolved
guides/plugins/apps/storefront/customize-templates.md Outdated Show resolved Hide resolved
guides/plugins/apps/storefront/customize-templates.md Outdated Show resolved Hide resolved
guides/plugins/apps/storefront/customize-templates.md Outdated Show resolved Hide resolved
guides/plugins/apps/storefront/customize-templates.md Outdated Show resolved Hide resolved
guides/plugins/apps/storefront/customize-templates.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Isengo1989 Isengo1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Isengo1989 Isengo1989 merged commit 9d59536 into main Nov 10, 2023
3 checks passed
@Isengo1989 Isengo1989 deleted the DX-470/add-app-content branch November 10, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants